Skip to content

Commit

Permalink
fix: add v12_language_service/node_modules to release package (#1826)
Browse files Browse the repository at this point in the history
* build: add missing vscode-nls to npm_translate_lock hoisted package

* fix: add v12_language_service/node_modules to release package
  • Loading branch information
gregmagolan authored Nov 30, 2022
1 parent 199a88a commit a7cde7e
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 0 deletions.
1 change: 1 addition & 0 deletions .bazelignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
node_modules/
v12_language_service/node_modules
dist/
integration/pre_apf_project/node_modules/
integration/project/node_modules/
Expand Down
4 changes: 4 additions & 0 deletions WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,10 @@ npm_translate_lock(
yarn_lock = "//:yarn.lock",
package_json = "//:package.json",
npmrc = "//:.npmrc",
data = [
"//:pnpm-workspace.yaml",
"//v12_language_service:package.json",
],
verify_node_modules_ignored = "//:.bazelignore",
public_hoist_packages = {
# Hoist transitive closure of npm deps needed for vsce; this set was determined manually by
Expand Down
2 changes: 2 additions & 0 deletions pnpm-workspace.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
packages:
- v12_language_service
8 changes: 8 additions & 0 deletions v12_language_service/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,8 +1,16 @@
load("@npm//:defs.bzl", "npm_link_all_packages")

npm_link_all_packages(name = "node_modules")

filegroup(
name = "npm_files",
srcs = [
"package.json",
"yarn.lock",
# There are needed for backward compat with Angular v12.
# See https://github.com/angular/vscode-ng-language-service/issues/1821.
":node_modules/@angular/language-service",
":node_modules/@angular/language-server",
],
visibility = ["//:__pkg__"],
)

0 comments on commit a7cde7e

Please sign in to comment.