fix: use single entry point for @angular/language-service #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyliau
added
the
blocked
|
Blocked on v12.0.0-next.3 release, CI failure is expected until then |
atscott
approved these changes
Mar 1, 2021
kyliau
force-pushed
the
single-entry-point
branch
from
8ce808e to
9d2b357
Compare
Starting from `@angular/language-service` v12.0.0-next.3, the package will dynamically load View Engine or Ivy LS based on the config passed to the plugin. This reverts angular#1111
kyliau
force-pushed
the
single-entry-point
branch
from
9d2b357 to
f8f6ab2
Compare
kyliau
removed
the
blocked
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting from
@angular/language-servicev12.0.0-next.3, the packagewill dynamically load View Engine or Ivy LS based on the config passed
to the plugin.
This reverts #1111