(Updated on 2021.12.29) Many changes Can't Title Summarize #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed EGS Comics pre-loading.
Just a minor change to change the version/date
Fixed: Kevin and Kell Dominic Deegan GrrlPower Keychain of Creation Three Panel Soul Major Changes: Converted HTTP and HTTPS matching to HTTP* to future proof. This may have fixed several sites previously noted for being broken. This was the case for atleast Keychain of Creation. May have to go over the broken list again.
(no real changes made, just wanted to list what sites did get fixed in the last change) Sites fixed due to switching to "http*" biggercheese.com/ bittersweetcandybowl.com/ bringbackroomies.com/ buckocomic.com/ https://www.c.urvy.org/ collectedcurios.com/ doctorcatmd.com/ dynasty-scans.com/ garfieldminusgarfield.net/ giantitp.com/ gpf-comics.com/ little-gamers.com/ meekcomic.com/ mrlovenstein.com/ pebbleversion.com/ pointguardian.com/ project-apollo.net/mos/ satwcomic.com/ scarygoround.com/ sevensmith.net/chirault/ - Front page broken supercrash.net/ vgcats.com/ webtoons.com/ - Slightly broken, pages don't show up till you scroll down a little
Fixed LFG Added KemonoCafe Known Todo Currently: CAD Comic Curtailed Comic Dilbert Lackadaisy Cats DMFA Vicki Fox Homestuck Three Panel Soul - Front Page breaks the script.
Fixed DMFA/MissMab, Curtailed, and initial Homestuck work When Homestuck changed to the new domain, it also got a revamped site. it no longer requires the multiple entries for detection depending on various things like which act we're in. This is good. It however decided to be a pain to setup for whatever reason. Took several hours but I managed to get it finally. It properly shows the image, the Pesterchat, and even the nav link. But since the link wasn't automatically switching to being #next, I used some JS to make it like the image and navigating by clicking left or right on it's box. The other comics on the site, like Problem Sleuth aren't setup yet. That's on the way. Also AppleGeeks is being a big pain in getting to work. Two days (on and off) have been wasted trying to get that to work. Also think I forgot several commits ago to mention I fixed some Kevin and Kell aligning problems, particularly on smaller screens like phones. Current List of To Fix: Yosh Saga Artificial Incident Dilbert Lackadaisy Cats Vicki Fox Three Panel Soul (minor fix due to the front page) The various sites that have been moving off of Katbox that aren't ending up on Kemono Cafe Two Kinds
More Homestuck. I had previously remembered to capture the pesterchat and nav stuff, but forgot the story text that sometimes up
Fixes to some alignment styling for Kevin and Kell
Added Yosh Saga and Artificial Incident Fixed Vicki Fox Previous comitt: Added Fullscreen. Primarily for Mobile Users to clear up realestate. Examples: https://i.imgur.com/09x8xMJ.png https://i.imgur.com/ThrFZfg.png Also note for mobile users: It may be best to either enable "Request Desktop site" in the browser, or enable Fit-to-Screen with shrink width to fit enabled. Maybe on newer phones it isn't an issue, but on a Samsung S4 I've been testing this on, it likes to display pages zoomed in. And while in Fullscreen you can't zoom out.
Solved: Hopefully fixed one or two issues with Dominic Deegan. Mainly a mobile issue, will have to check back after upping this. Kevin and Kell had a minor issue with detecting first and last. Back up and running: Dilbert Lackadaisy Cats Added in default styling for buttons and dropdown. This should solve any issues where the site would override the buttons and what not to be obscenely large, small, or just didn't look like buttons. Coloring was also applied in the event that your system's color scheme made the text unreadable.
Nothing really. still trying to get applegeeks to work, it doesn't want to detect next and previous... This just contains the latest edit, incase i ended up working on it this weekend.
Setup default appearances for settings buttons. as well as setting a width to the settings dialog. Need to remember later to set the default font and size later. Also minor addition to Kevin and Kell, listing the page's title as an extra. Which appears to have been in the original setup. Contemplating if I should add in the comments section to the extra section as well. Might test it to see how much of a problem it causes since it's using Disqus. Added in the ability to browse FA's galleries if they weren't on a comic page. Though if a comic page that uses the built in comic nav system hits the queue it will start going into that comic's pathing. Might have to look into some JS to get it to go "if I started in viewing Gallery images, stay in gallery navigation". It's a minor issue that might be a little annoying. Also added the native gallery queue to the extra. Will work on styling for it later. ....still no luck on AppleGeeks. What I have SHOULD be working from what I can tell. It's just... not....
Well the Kevin and Kell extra change from last comitt was a bust. Because the title also contains a bit of javascript to detect how many comments are made on that page, it causes the image to have a lag time when switching pages. Also found out that the "Disable on this site" button also only appears on mobile, maybe even just for the mobile version of greasemonkey. Will look into this more with tampermonkey as well. Would like to style these buttons, but they only have text and nothing else to ID them. And since CSS doesn't have a selector for what a tag contains between it... I even have to wonder if Javascript can touch the buttons since they should technically be added only after the script has ran. I thought of several solutions, but they have their down sides 1. Default style for all buttons. -Problem: This affects all buttons on a site 2. Use nth last child of type css selector to select the last button -Problem: If this is ran outside of mobile, this will affect the last two buttons on a page. 3. Appended a hidden button towards the end of the page via script -Problem: Too much effort for a minor thing. These three are not ideal.
Testing to see if mobile and userscript engine detection stuff
A lot of these commits today will be related to trying to deal with the appearance of the buttons greasemonkey puts in on mobile for script menu command entries.
Primarily so I have a easy way to install and debug the script on mobile
Fixed Free Fall. It wasn't detecting the comic page for the first 300-ish pages in the archive. Also styling for the GreaseMonkey "disable for this site" has been implemented. Will look into manually including the button for Tampermonkey users later.
getting commit history transfered over Pt.1
getting commit history transfered over Pt.2
Author
|
Too late, fixed it :P (in the round-about method) |
Owner
|
No problems :) |
Notice while re-reviewing the compare list that one section of the XPath correction put forth by roryokane got undone. Also undid my last one as I noticed it put a lot of things out of line, more so that it should have. *headdesk*
(I should really stop making commits after I've submitted a pull request, but I kept finding stuff, hopefully this is the last) Minor: Went through and cleaned up some alignment stuff via tabs indents. Found some spaces I missed prior, gave a glance at things to make sure they aligned in a uniform fashion.
Realized that I could do the exclusion on image files a bit better. So now it'll run on the rare site that decides to have something like index.php?file=thisimagefile.jpg (see Fur Will Fly for an example of this listing style (FWF can't be captured eitherway because the site forces HTTPS protocol in the URL, but doesn't actually transmit via the standard)) `// @exclude /^(?!.*(?:\.html|\.php|\?|\=)).*(jpg|jpeg|png|gif)$/` Also shrunk the includes and captures for dhscomix with some regex. Not only to save space, but also to auto-capture new subcomics they create. `// @include /^https?://(www\.|)dhscomix.com/.*comics/.*$/`
Redid Girl Genius's Extra capture. Didn't like how it didn't scroll. And after several attempts at creating a variation of the extra navigation function to do auto scrolling (scrollear() prevents this), I redid the capture setup. It resulted in less space used. Also, during a re-read of EGS, I noticed that every so often Dan would have a link that went to a "alt" image. I put in a capture for that to display it (at 50% width to differentiate it in cases where he's showing off that he made an edit, and thus not-canon)
EGS and GG's extra captures got updated. EGS's needed it's last update duplicated to it's www variant GG's now is set to be an inline-block to fix issues in minimal. As well as making the news/commentary notes actually visible due to some CSSing that occurred Also I added MacHall to the captures. It's a long finished comic from ages ago. It was part of the big old school trio (MacHall, AppleGeeks, & MegaTokyo). Still no word on getting applegeeks captured.... (I realize I keep adding stuff to the pull that I put up. Atleast I'm limiting it to once every several weeks)
Alien Dice added
Trying something new, since I'm gonna go through Alien Dice's archive, I decided to throw in some extra catches for the comic image detection. In the off chance there are pages with multiple images. I don't recall there being any such pages in the archives, but it is something that I wanted to test out anyway. And become a common practice with me on sites that I add personally.
Minor fix (non-ideal) for the "latest page" of Girl Genius. Added the rest of Shivae Comics, as well as a minor fix for Alien Dice. Still have to look into several issues with these sites, primarily the lack of overflow scrolling, as well as the sites managing to color the setting window's buttons. Would take care of it now but I barely got the time for it right this minute.
Comics added: Added Alice and the Nightmare Comic Fixes: Fixed Misfile furaffinity non-www pages smackjeeves's @include removed (defunct). Left capture rules for use within the internet archive e*hentai's body 2px padding removal Other Fixes: max width on recent/loaded pages drop box
.... Properly fixed the pages dropbox this time, forgot to move a bracket Also converted First and Last into buttons to make it more visually cohesive.
Testing fix for dimming on mobile not properly covering when scrolling.
Realized that NAV Comic never got added. Side note: seems the dimming fix has mostly worked. Particularly on minimalist mode, the only issue I'm seeing is on some sites where they have a background image (artificial incident for an example) the background image still has the same issue. But that may be less of an issue due to WCR outside of minimalist view.
Author
|
So finally working on this again (in a branch which I'll merge into this pull request) The problem I'm having right now is that the english translation... made a bit of a mess of things. Not on their part, mind you. It's gone and created a lot of conflicts that I have to go in manually. I thought I could just use github's desktop app to rebase and what not... buuuuuuuut! It's not great. It doesn't even use the complete history of changes I made in the branch I'm working in, only up to July of last year, for some reason. So, what I'm basically going to have to do is manually replace all the translation stuff into my fork. Plus it'd probably be a lot quicker than having to go through the 100+ changes it wants me to check every, single, time. It wanted to open every single conflict in my editor. A lot of them were going from four spaces to tab spaces. Though some of them are related to functions and new sites. When I'll get this done, I do not know. I'll basically have a week free from everything, because I just moved, the ISP tech is swamped and can't setup the lines till next week at the earliest. And with the power of not-hotspotting with a smartphone, the only thing I can really do with my internet connection is browse the web, watch videos, and play games I've already downloaded. So yeah, got free time for that now, minus some more moving related stuff. But yeah, got a bunch of stuff to add to this pull, fixes, visual cohesion stuff, new sites, and what not in the works. Trying to keep myself from adding more stuff till I get the translation stuff pulled in. Again, sorry it's taken so long to get around to doing this. |
Had to semi-manually update my file to get it rebased to anka main. Came across GitKraken and it saved me hours, maybe even days, manually going through copying and pasting. Sadly due to a issue on my end (temporary internet connection related) I couldn't submit it via that. But this does bring it up to the main's english translation changes.
Update to latest Fixes and additions Branch
Author
|
Managed to get the translation inserted sooner (thanks to GitKraken. Found it earlier, not long after my last comment, it's been nice so far in it's small test). Still had to do some manual stuff. Saved me probably a few days of eye sore work. Updated first comment to include the changes made. Not too much changed, some sites added, some sites tweaked, unified navigation buttons, some mobile related fixes (such as dimmed mode having issues while scrolling). Also resolved the github file conflicts that would come up, of course. Things should be good to go for a merge in if deemed so. For the most part I've been using my own dev branch for the past year or so, so I can basically say that the major changes have been working just fine. And I haven't made much major additions/changes during that time due being dragged from one corner of the USA, to basically it's opposite, for a year. It should be a while before I submit anything new to be pulled into the project. Such as more sites, as well as some feature tweaks. So there are things I still want to do, but that can wait for a later pull. edit: also fixed this in the process #158 |
SoraHjort
changed the title
SoraHjort
changed the title
Owner
|
I’ll go ahead and merge this now so more people can get access to all your fixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr: many changes were made, please review changes and test stuff out before going with a merge.
(Due to a woops I made at one point, it's being pulled from a new sub-branch. The actual full change history log: https://github.com/SoraHjort/webcomic_reader/commits/Fixes-and-Additions/webcomic_reader.user.js )
This is about a year in the making (on and off a lot). It shouldn't have taken that long, but I kept getting side tracked, fixing comics I was reading at the time, forgetting about it, and so on.
This started off as a branch to just add and fix comics before putting in pull requests. It then went into adding several features and other stuff. I am stuck in a "what do I do next" slump, which is why I'm putting it out now. I think I'm mostly done. But I would like feedback on the changes and the like.
If it comes down to it, and the changes I've made are not acceptable, I could separate the additions/fixes for sites.
Highlights:
@includeshave been updated to be "http*://" instead of http and https toa. save space when it comes to duplicates
b. future proof in case a domain goes from http to https
c. more strict capture than simply going "*://" to prevent running on, say, ftp:// or any other protocol.
Please give this a good look over and test it out. I'm the kind of person to be paranoid over my own work when it's this big of a change. I worry I might have broken something, despite not running into any issues in the months I've been using my dev branch exclusively). Heck I'm still paranoid if I'm doing pulls correctly.
Thankfully, I kept notes on note worthy changes( IE: not every time I had to edit because I goofed)
The full change summary:
(Note on Site fixes and added sites, if they've changed since I've made those changes, and no longer work, sorry for the inconvenience.)
Sites Fixed:
Sites Added:
Site tweaks:
Ahab's White Whale: Apple Geeks, it doesn't deserve to be, but it's doing it's darnest to be it.
Features and Big Changes:
Full screen button. Primarily useful for Mobile users, but who knows what desktop users could use it for! https://youtu.be/TKl02m4lkJc?t=88
(Mobile only) A Disable/Enable This Script button at the bottom of the page. Greasemonkey on mobile already does this, as it inserts menu commands as a button. This makes it universal regardless if it's greasemonkey or tampermonkey. As well as not a tiny button for mobile users.
Script's buttons have a default style
Various Colors (buttons, settings menu) fixed to not be affected by OS's color scheme
Several more color and styling fixes
Script now does not load on image files (png, JPG, gif, etc). This was mainly an issue on mobile from what I've seen.
Non-Dynamically Colored Buttons now get darker when pressed.
The Dimming background now overextends width and height to fix an issue on mobile when it came to scrolling
Pages Dropbox now have a max size of 100% (not all browsers have been updated to allow min()/max() yet, otherwise it would be 500px or 100%)
Settings window has had various updates to give a more uniform size and feel across each page.
wcr_ext_navi_ctrls: a function that can be called in js: for automatically turning the extra section into a navigable part.
All includes have been future proofed by switching from HTTP and HTTPS to HTTP*. Should prevent the script from breaking if a site switches between them.
Sites fixed due to switching to "http*" (checked back in october/november 2019)
biggercheese.com/
bittersweetcandybowl.com/
bringbackroomies.com/
buckocomic.com/
https://www.c.urvy.org/
collectedcurios.com/
doctorcatmd.com/
dynasty-scans.com/
garfieldminusgarfield.net/
giantitp.com/
gpf-comics.com/
little-gamers.com/
meekcomic.com/
mrlovenstein.com/
pebbleversion.com/
pointguardian.com/
project-apollo.net/mos/
satwcomic.com/
scarygoround.com/
sevensmith.net/chirault/ - Front page broken
supercrash.net/
vgcats.com/
webtoons.com/ - Slightly broken, pages don't show up till you scroll down a little (fixed? I didn't do anything, but it hasn't happened in a while)
-Post note-
Ahab's White Whale: Apple Geeks, it doesn't deserve to be, but it's doing it's darnest to be it.
I tried, many, many, many times to get it to work with it to no avail. It's... it's weird. Maybe one day I'll try again, but if someone wants to give it ago, go ahead. It's like it ignores the capture rules and instead wants to grab the banner image as "Back", despite the xpath being completely different.
There are also other ideas I do want to implement at some point, but I need to land on stable ground, script wise, before progressing on those fronts. Sorry it took nearly a year to get this going, but, well... those changes. And procrastination.