Skip to content

call onScroll event on failed attempt to scroll down #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

call onScroll event on failed attempt to scroll down #349

wants to merge 1 commit into from

Conversation

rahulakrishna
Copy link

Changes

  • Add a listener on wheel events
  • detect the wheel direction and for cases with no scroll bar, call the onScroll event

How to Test

src/stories/WindowInfiniteScrollComponent.tsx, change the Array length to a lower number.
image

Resolves: loader doesn't appear when page is bigger than InfiniteScroll #345

@rahulakrishna
call onScroll event on failed attempt to scroll down
288e9c6 
Resolves: loader doesn't appear when page is bigger than InfiniteScroll ankeetmaini#345
@rahulakrishna
Copy link
Author

@ankeetmaini can we merge this?

@pablomikel
Copy link

+1
encountering this issue as well and this would be a welcome fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rahulakrishna @pablomikel