Skip to content

fix long screen issue #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix long screen issue #381

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51937f7
fix long screen issue
ardeshiir May 1, 2023
81c9c3e
add 300px threshold for long screens fetch again
ardeshiir May 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,12 +143,21 @@ export default class InfiniteScroll extends Component<Props, State> {
// do nothing when dataLength is unchanged
if (this.props.dataLength === prevProps.dataLength) return;

this.actionTriggered = false;

// update state when new data was sent in
this.setState({
showLoader: false,
});
const fetchAgain =
this._infScroll &&
this._scrollableNode &&
this._scrollableNode.clientHeight + 300 > this._infScroll.scrollHeight;
if (fetchAgain) {
this.actionTriggered = true;
this.setState({ showLoader: true });
this.props.next();
} else {
this.actionTriggered = false;
// update state when new data was sent in
this.setState({
showLoader: false,
});
}
}

static getDerivedStateFromProps(nextProps: Props, prevState: State) {
Expand Down