Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline signatures from SDK #4234

Merged
merged 5 commits into from
Jan 16, 2025
Merged

Offline signatures from SDK #4234

merged 5 commits into from
Jan 16, 2025

Conversation

grarco
Copy link
Collaborator

@grarco grarco commented Jan 14, 2025

Describe your changes

This PR moves the offline signing logic from the client to the SDK.
Also removes some remaining traces of SignTx which is a duplicated of OfflineSign (I had already started removing it in #4120 but forgot to remove everything).

I've also opened #4235 with some followup tasks on this topic.

cc: @jurevans

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

grarco added a commit that referenced this pull request Jan 14, 2025
@grarco grarco added SDK breaking:SDK SDK breaking change labels Jan 14, 2025
@grarco grarco marked this pull request as ready for review January 14, 2025 12:34
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 86.84211% with 5 lines in your changes missing coverage. Please review.

Project coverage is 74.59%. Comparing base (c0b9f68) to head (bc68286).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
crates/sdk/src/signing.rs 86.84% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4234   +/-   ##
=======================================
  Coverage   74.59%   74.59%           
=======================================
  Files         342      342           
  Lines      108724   108762   +38     
=======================================
+ Hits        81101    81132   +31     
- Misses      27623    27630    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grarco grarco force-pushed the grarco/offline-sigs-in-sdk branch from 461936b to af4dd97 Compare January 14, 2025 14:19
@brentstone brentstone added this to the v1.1.0 milestone Jan 15, 2025
@brentstone
Copy link
Collaborator

@tzemanovic @grarco adding this to the v1.1.0 milestone - any concerns here?

@grarco grarco added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Jan 16, 2025
mergify bot added a commit that referenced this pull request Jan 16, 2025
@mergify mergify bot merged commit 7169a3f into main Jan 16, 2025
24 of 25 checks passed
@mergify mergify bot deleted the grarco/offline-sigs-in-sdk branch January 16, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking:SDK SDK breaking change merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants