-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase the accuracy of rewards by minting based on the real reward. #4369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4369 +/- ##
=======================================
Coverage 74.53% 74.53%
=======================================
Files 339 339
Lines 110504 110524 +20
=======================================
+ Hits 82359 82377 +18
- Misses 28145 28147 +2 ☔ View full report in Codecov by Sentry. |
grarco
approved these changes
Feb 12, 2025
batconjurer
reviewed
Feb 13, 2025
147c124
to
d5da654
Compare
batconjurer
approved these changes
Feb 13, 2025
sug0
approved these changes
Feb 14, 2025
d5da654
to
d413757
Compare
tzemanovic
approved these changes
Feb 27, 2025
3 tasks
mergify bot
added a commit
that referenced
this pull request
Feb 27, 2025
Increase the accuracy of rewards by minting based on the real reward. (backport #4369)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-libs-0.149
Backport libraries to 0.149 maintenance branch
MASP
merge
Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR is an attempt to slightly mitigate #4372 by reducing the amount of unclaimable rewards created by the rewards algorithm. The approach taken is to try and reduce the amount of NAM minted for non-native tokens so that it's closer to what can actually be claimed. And this reduction is achieved by minting NAM based on the deflated rewards for non-native tokens (which is what is actually put into the allowed conversions) rather than the inflated rewards they are based on. Because clients can combine (deflated) reward NAM[0] with pre-existing NAM[0] in their balance to meet the threshold for conversion to the current epoch and because the distribution algorithm now works with deflated amounts, it no longer ignores the dust arising during the mint amount computations.
To see the impact of this PR, note that the dust left at the MASP address after all shielded tokens are unshielded in https://github.com/anoma/namada/pull/4369/files#diff-78668f42dcc983dea532ff370112f41796cfae99510ea10156df37c4e1e4e0d2L2285 has gone down from
nam: 0.003216
tonam: 0.000012
.Checklist before merging
breaking::
labelsnamada-docs
reponamada-indexer
ornamada-masp-indexer
, a corresponding PR is opened in that repo