Repository navigation
feat(blackout): title, lobby, Escape menu and Settings on the shared game shell - #436
Merged
Merged
Conversation
…d on leaving, idle warning once; Play with friends note
… in its tooltip, stats beside Solo sandbox)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does. Blackout's landing page, pause and settings move onto the shared game shell (#431): the same title, lobby, Escape menu and Settings as every other Arcade game, with Blackout's mode and map picks on the title.
How it works.
src/main.tsbuilds the shell. The mode and map picks, Solo sandbox and live stats sit in the title slot (LandingPicksinsrc/ui/menus.ts).input.blocked), and held keys are let go on pausing. The Tab scoreboard shows only in play, and its pinned state clears on leaving.games/blackout/AGENTS.mdunder "Game shell".Risk. Blackout only: the landing and menus, input gating on the title and menu, and the scoreboard. Mux, practice, sandbox and rejoin links start straight in play as before.
Proof.
bun test --max-concurrency 4 packages/kit/shell.test.ts packages/kit/architecture-map.test.ts: 25 pass.bun test --max-concurrency 4 tests/host-controls.test.ts tests/lighting.test.ts: 14 pass.tscfor Blackout: clean.bun scripts/prove-game-shell.ts blackout: title, Settings, lobby and pause; the title fits at 1280×720 and 1920×1080 (overflow 0).