fix(jest): ✏️ stick to jest expect convention#462
Open
cadesalaberry wants to merge 1 commit intoanomalyco:masterfrom
Open
fix(jest): ✏️ stick to jest expect convention#462cadesalaberry wants to merge 1 commit intoanomalyco:masterfrom
cadesalaberry wants to merge 1 commit intoanomalyco:masterfrom
Conversation
https://jestjs.io/docs/en/expect#tobevalue > Use .toBe() to compare primitive values or to check referential identity of object instances. `.toEqual()` is rather used to compare the content of an object. actual and expected values were also the other way around; The reference value is supposed to used as a parameter of the `toBe` function rather than the `expect` function.
cadesalaberry
changed the title
Contributor
|
Thank you. We'd need to update the code repos attached to this. I'll leave this open for now and update it once we update the guide. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://jestjs.io/docs/en/expect#tobevalue
.toEqual()is rather used to compare the content of an object.actual and expected values were also the other way around; The reference value is supposed to used as a parameter of the
toBefunction rather than theexpectfunction.