Skip to content

fix: allow partial provider model limits#32320

Open
wgu9 wants to merge 1 commit into
anomalyco:devfrom
wgu9:wgu9/fix-provider-limit-partial
Open

fix: allow partial provider model limits#32320
wgu9 wants to merge 1 commit into
anomalyco:devfrom
wgu9:wgu9/fix-provider-limit-partial

Conversation

@wgu9

@wgu9 wgu9 commented Jun 14, 2026

Copy link
Copy Markdown

Issue for this PR

Closes #31780

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Provider model limit config supports input, context, and output, but the schema required context and output together. That made valid partial overrides fail, such as setting only context for a model.

This PR makes each token limit field independent while preserving the same numeric validation. It also adds regression coverage for context-only, output-only, and input-only limit config.

The duplicate check found a related provider limit PR, but this PR is scoped to the existing schema behavior for partial model limits.

How did you verify your code works?

  • bun test test/config/config.test.ts

Screenshots / recordings

Not applicable. This is a config schema fix covered by a regression test.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@github-actions github-actions Bot added the needs:compliance This means the issue will auto-close after 2 hours. label Jun 14, 2026
@github-actions

Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

Based on my search results, I found one potentially related PR:

  • PR feat(provider): support per-model limit overrides in user config #29354: feat(provider): support per-model limit overrides in user config - This PR appears to address similar functionality regarding per-model limits in user configuration, which is related to the current PR's focus on allowing partial provider model limits to be configured independently.

However, this is a related feature PR rather than a duplicate. The current PR (32320) is a bug fix that allows partial provider model limits, while PR #29354 is a feature addition for per-model limit overrides.

No duplicate PRs found

@github-actions github-actions Bot removed the needs:compliance This means the issue will auto-close after 2 hours. label Jun 14, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for updating your PR! It now meets our contributing guidelines. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Provider config schema requires limit.output when limit is present - config fails if output omitted

1 participant