fix: allow partial provider model limits#32320
Open
wgu9 wants to merge 1 commit into
Open
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Based on my search results, I found one potentially related PR:
However, this is a related feature PR rather than a duplicate. The current PR (32320) is a bug fix that allows partial provider model limits, while PR #29354 is a feature addition for per-model limit overrides. No duplicate PRs found |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #31780
Type of change
What does this PR do?
Provider model
limitconfig supportsinput,context, andoutput, but the schema requiredcontextandoutputtogether. That made valid partial overrides fail, such as setting onlycontextfor a model.This PR makes each token limit field independent while preserving the same numeric validation. It also adds regression coverage for context-only, output-only, and input-only limit config.
The duplicate check found a related provider limit PR, but this PR is scoped to the existing schema behavior for partial model limits.
How did you verify your code works?
bun test test/config/config.test.tsScreenshots / recordings
Not applicable. This is a config schema fix covered by a regression test.
Checklist