fix: skip empty reasoning steps in replayed history#37624
Open
mihneaptu wants to merge 1 commit into
Open
Conversation
Contributor
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Fixes #37651
Context: #37552 documented two independent 400 paths for Kimi K3 on OpenCode Go. The
temperaturepath was fixed in models.dev#3331; this PR fixes the remaining history-replay path, now tracked in #37651.Type of change
What does this PR do?
Skips metadata-free empty reasoning parts while rebuilding model history. Some providers can open and close a reasoning stream without emitting a delta; replaying that boundary previously produced an empty assistant message before the next step.
How did you verify your code works?
step-start/ empty-reasoning sequence.bun test test/session/message-v2.test.ts: 37 passed.Screenshots / recordings
Not applicable.
Checklist