fix(tui): stabilize dialog mouse selection#37674
Open
opencode-agent[bot] wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #37663
Type of change
What does this PR do?
Stops
DialogSelectfrom recentering when a mouse-driven selection is mirrored back throughcurrent. That recenter moved rows beneath a stationary cursor, which generated another hover event and created the selection flicker.Keyboard and external
currentchanges still use the existing centering behavior.How did you verify your code works?
current/onMovefeedback loop.bun testinpackages/tui(267 passed, 1 skipped)bun typecheckinpackages/tuiScreenshots / recordings
No static visual change. The mouse-driven regression test verifies the highlight remains on the hovered row rather than oscillating as the list recenters.
Checklist
Requested by: @rekram1-node (Aiden Cline via Slack)