Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/core/src/permission.ts
Original file line number Diff line number Diff line change
Expand Up @@ -170,14 +170,20 @@ const layer = Layer.effect(
return { effect, rules: all }
})

// Metadata is JSON-encoded; drop undefined values tools pass for absent optional inputs.
function metadata(value: AssertInput["metadata"]): Request["metadata"] {
if (!value) return value
return Object.fromEntries(Object.entries(value).filter(([, item]) => item !== undefined))
}

function request(input: AssertInput): Request {
return {
id: input.id ?? ID.create(),
sessionID: input.sessionID,
action: input.action,
resources: input.resources,
save: input.save,
metadata: input.metadata,
metadata: metadata(input.metadata),
source: input.source,
}
}
Expand Down
11 changes: 11 additions & 0 deletions packages/core/test/permission.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,17 @@ describe("PermissionV2", () => {
}),
)

it.effect("omits undefined metadata values from pending requests", () =>
Effect.gen(function* () {
yield* setup()
const service = yield* PermissionV2.Service
yield* service.ask(assertion({ metadata: { root: ".", path: undefined, limit: undefined } }))
const request = yield* service.get(PermissionV2.ID.create("per_test"))
expect(request?.metadata).toEqual({ root: "." })
expect(Object.keys(request?.metadata ?? {})).toEqual(["root"])
}),
)

it.effect("defects when an asked permission is declined", () =>
Effect.gen(function* () {
yield* setup()
Expand Down
Loading