fix(web): open project dialog not showing directories #8186
+50
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Three issues were preventing the Open Project dialog from working in web mode: 1. Server: query parameter was required but SDK sends empty string as undefined 2. Server: directory parameter was ignored, always searching current project 3. UI: useFilteredList hook didn't properly handle async items function Changes: - Make query parameter optional with default empty string - Add directory parameter support to /find/file endpoint - Implement directory scanning when directory param is provided - Fix useFilteredList to properly await async items functions - Add null-safety to filter.trim() call in dialog
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Based on my search, I found one potentially related PR: Related PR:
Note: PR #6940 "feat: improve directory search with path completion and subdirectory listing" appeared in search results but is likely a related feature enhancement rather than a duplicate fix. |
Contributor
|
Thanks for the contribution, but we got this fixed this morning! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Three issues prevented the Open Project dialog from working:
queryparameter was required but SDK sends empty string asundefined, causing 400 Bad Requestdirectoryparameter was ignored, always searching current project directory instead of homeuseFilteredListhook didn't properly handle async items function, causing Promise to be used as arrayChanges
packages/opencode/src/server/server.tsqueryparameter optional with default empty stringdirectoryparameter support to/find/fileendpointdirectoryparam is provided (2 levels deep)packages/ui/src/hooks/use-filtered-list.tsxcreateResourcesource function to not call async functions synchronouslypackages/app/src/components/dialog-select-directory.tsxfilter.trim()callTesting
Tested locally with
opencode web- dialog now shows home directories and search works correctly.