ci(nix): simplify desktop app packaging #8998
Conversation
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
simplifies desktop app packaging by using cargo-tauri.hook brings build provess more in line with other platforms fixes anomalyco#8962
gigamonster256
force-pushed
the
push-xzuuomykqslk
branch
from
56a00d4 to
30aaac6
Compare
| postInstall = lib.optionalString stdenv.isLinux '' | ||
| # Wrap the binary to ensure it finds the libraries | ||
| wrapProgram $out/bin/opencode-desktop \ | ||
| wrapProgram $out/bin/OpenCode \ |
There was a problem hiding this comment.
Do not use case sensitive name that will collide with opencode on any case insensitive file system. Binary name is standardized: no space, etc. Do not change the name of an already shipped binary, already defined name at build, ...
There was a problem hiding this comment.
the desktop app ships as "OpenCode" on every other platform (ls showing extracted 1.1.25 releases for deb, rpm, and darwin app)
And i'm not changing the name of the binary, thats what the tauri bundler outputs
There was a problem hiding this comment.
If that's true, it's a serious namespace collision between the TUI and the GUI binary that should be addressed and will break on most macOS installation. And bug should be opened.
|
superseded by #9032 |
2 participants
simplifies desktop app packaging by using cargo-tauri.hook brings build provess more in line with other platforms fixes #8962 and #8971
should be compatible with darwin as well since the cargo-tauri hook also work