fix(lsp): Clear diagnostics and files maps on client shutdown #9144
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clear internal LSP client maps on shutdown to prevent memory leaks in long-running sessions: - Clear diagnostics Map (growing indefinitely with file edits) - Clear files version tracking object
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Potential Duplicate FoundPR #7050: "fix: add LRU eviction to LSP client file and diagnostics tracking" Why it's related: This PR also addresses memory management issues with the LSP client's diagnostics and files tracking. While PR #9144 takes a shutdown-based cleanup approach, PR #7050 implements LRU (Least Recently Used) eviction as a solution to the same underlying problem of memory retention in the LSP client. They may be addressing overlapping concerns about the You may want to check if PR #7050 was merged and whether it already resolves the issues mentioned in #9143 and #5363. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Properly clean up LSP client resources when the underlying LSP server process disconnects or exits.
Fixes #9143
Relates to #5363
Problem
When an LSP client shuts down, the
diagnosticsMap andfilesobject are not cleared. This can cause:Solution
Add cleanup logic in the LSP client
shutdown()method to:diagnosticsMapfilesobjectChanges
packages/opencode/src/lsp/client.ts- Add cleanup in shutdown() methodTesting
bun turbo typecheck)Note: Manual LSP server disconnect testing was not performed.