fix(acp): Fix memory leak in session event streams #9146
+73
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add proper cleanup for ACP (Agent Communication Protocol) sessions to prevent resource leaks from orphaned sessions.
Fixes #9154
Relates to #5363
Problem
When ACP sessions are created:
Solution
Add proper session lifecycle management:
Changes
packages/opencode/src/acp/session.ts- Add session cleanup logicTesting
bun turbo typecheck)Note: Manual ACP session cleanup testing was not performed.