Skip to content

Conversation

@kdueck84
Copy link

@kdueck84 kdueck84 commented Nov 14, 2025

fix-nfs-options

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request

Problem

The proxmox_storage module exposes an options parameter under nfs_options,
but the module never passes this value to the API payload.

Fix

  • Add missing options to NFS storage payload

Result

NFS mount options are now correctly applied when creating or updating NFS
storage definitions on Proxmox.

fix-nfs-options
@Thulium-Drake
Copy link
Collaborator

Thanks for this! Can you please add a changelog fragment? :-)

@codecov
Copy link

codecov bot commented Nov 15, 2025

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.42%. Comparing base (9a176e2) to head (c4bc93c).

Files with missing lines Patch % Lines
plugins/modules/proxmox_storage.py 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #221      +/-   ##
==========================================
- Coverage   66.43%   66.42%   -0.02%     
==========================================
  Files          73       73              
  Lines        7437     7440       +3     
  Branches     1404     1405       +1     
==========================================
+ Hits         4941     4942       +1     
  Misses       2264     2264              
- Partials      232      234       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants