add details on some plugin options - AI-assisted #2813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay made the changes. Can you take another look @felixfontein ? |
samccann
commented
Jul 16, 2025
Co-authored-by: Felix Fontein <[email protected]>
samccann
commented
Jul 16, 2025
felixfontein
approved these changes
Jul 16, 2025
oraNod
reviewed
Jul 21, 2025
Co-authored-by: Don Naro <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
felixfontein
approved these changes
Jul 22, 2025
oraNod
approved these changes
Jul 24, 2025
Co-authored-by: Andrew Klychkov <[email protected]>
samccann
added
the
backport-2.17
samccann
added
backport-2.18
Backport to stable-2.17: 💚 backport PR created✅ Backport PR branch: Backported as #2899 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jul 24, 2025
* add details on some plugin options * revise based on feedback * Apply suggestions from code review Co-authored-by: Felix Fontein <[email protected]> * Update docs/docsite/rst/dev_guide/developing_plugins.rst * Apply suggestions from code review Co-authored-by: Don Naro <[email protected]> * add examples * Update docs/docsite/rst/dev_guide/developing_plugins.rst Co-authored-by: Felix Fontein <[email protected]> * Apply suggestions from code review Co-authored-by: Andrew Klychkov <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]> Co-authored-by: Don Naro <[email protected]> Co-authored-by: Andrew Klychkov <[email protected]> (cherry picked from commit caa2399)
Backport to stable-2.18: 💚 backport PR created✅ Backport PR branch: Backported as #2900 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jul 24, 2025
* add details on some plugin options * revise based on feedback * Apply suggestions from code review Co-authored-by: Felix Fontein <[email protected]> * Update docs/docsite/rst/dev_guide/developing_plugins.rst * Apply suggestions from code review Co-authored-by: Don Naro <[email protected]> * add examples * Update docs/docsite/rst/dev_guide/developing_plugins.rst Co-authored-by: Felix Fontein <[email protected]> * Apply suggestions from code review Co-authored-by: Andrew Klychkov <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]> Co-authored-by: Don Naro <[email protected]> Co-authored-by: Andrew Klychkov <[email protected]> (cherry picked from commit caa2399)
Backport to stable-2.19: 💚 backport PR created✅ Backport PR branch: Backported as #2901 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jul 24, 2025
* add details on some plugin options * revise based on feedback * Apply suggestions from code review Co-authored-by: Felix Fontein <[email protected]> * Update docs/docsite/rst/dev_guide/developing_plugins.rst * Apply suggestions from code review Co-authored-by: Don Naro <[email protected]> * add examples * Update docs/docsite/rst/dev_guide/developing_plugins.rst Co-authored-by: Felix Fontein <[email protected]> * Apply suggestions from code review Co-authored-by: Andrew Klychkov <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]> Co-authored-by: Don Naro <[email protected]> Co-authored-by: Andrew Klychkov <[email protected]> (cherry picked from commit caa2399)
samccann
added a commit
that referenced
this pull request
Jul 24, 2025
* add details on some plugin options * revise based on feedback * Apply suggestions from code review * Update docs/docsite/rst/dev_guide/developing_plugins.rst * Apply suggestions from code review * add examples * Update docs/docsite/rst/dev_guide/developing_plugins.rst * Apply suggestions from code review --------- (cherry picked from commit caa2399) Co-authored-by: Sandra McCann <[email protected]> Co-authored-by: Felix Fontein <[email protected]> Co-authored-by: Don Naro <[email protected]> Co-authored-by: Andrew Klychkov <[email protected]>
samccann
added a commit
that referenced
this pull request
Jul 24, 2025
* add details on some plugin options * revise based on feedback * Apply suggestions from code review * Update docs/docsite/rst/dev_guide/developing_plugins.rst * Apply suggestions from code review * add examples * Update docs/docsite/rst/dev_guide/developing_plugins.rst * Apply suggestions from code review --------- (cherry picked from commit caa2399) Co-authored-by: Sandra McCann <[email protected]> Co-authored-by: Felix Fontein <[email protected]> Co-authored-by: Don Naro <[email protected]> Co-authored-by: Andrew Klychkov <[email protected]>
samccann
added a commit
that referenced
this pull request
Jul 24, 2025
* add details on some plugin options * revise based on feedback * Apply suggestions from code review * Update docs/docsite/rst/dev_guide/developing_plugins.rst * Apply suggestions from code review * add examples * Update docs/docsite/rst/dev_guide/developing_plugins.rst * Apply suggestions from code review --------- (cherry picked from commit caa2399) Co-authored-by: Sandra McCann <[email protected]> Co-authored-by: Felix Fontein <[email protected]> Co-authored-by: Don Naro <[email protected]> Co-authored-by: Andrew Klychkov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2673
Should have done this in 2 commits (AI-generated, then human adapted). Lines 78-93 are predominantly generated.
To fix this bug, I fed the following into Cursor chat mode:
Fix the documentation problems from @https://github.com/ansible/ansible-documentation/issues/2673