Advise about f-string in Python 3.6+ #3173
Open
+9
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Advise user about f-string in Python 3.6+ Signed-off-by: Abhijeet Kasurde <[email protected]>
webknjaz
reviewed
Oct 24, 2025
Comment on lines
380
to
+389
| b_command_line = b'ansible-playbook --become-user %s -K %s' % (user, playbook_file) | ||
| Use f-strings for Python 3.6+ | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
|
||
| In Python 3.6 and later, f-strings (formatted string literals) are a more readable and concise way to format strings. | ||
|
|
||
| .. code-block:: python | ||
| b_command_line = f"ansible-playbook --become-user {user} -K {playbook_file}" |
There was a problem hiding this comment.
I'm not happy with these examples show constructing commands through string concatenation. This is a straight way to command injection. These must use shlex.quote() / shlex.join().
It'd be better to use something else in examples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Signed-off-by: Abhijeet Kasurde [email protected]
ISSUE TYPE
COMPONENT NAME
docs/docsite/rst/dev_guide/developing_python_3.rst