chore: Updated some of the docs and messages around setting pipefail. #4585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't seem to add a label, does someone else need to do that? |
audgirka
approved these changes
Apr 23, 2025
audgirka
force-pushed
the
update-pipefail-docs
branch
from
8ff00cd to
d0ba67d
Compare
Setting pipefail necessitates other changes away from the default functioning of ansible, this is made more explicit to the user.
dylanmorroll
force-pushed
the
update-pipefail-docs
branch
from
1e5b103 to
a72212a
Compare
|
Tweaked it to pass pipeline checks :) |
ssbarnea
requested changes
May 13, 2025
There was a problem hiding this comment.
Maybe I am missing something but what is the 'standard (POSIX) shell' from your point of view? AFAIK, there is no such software product.
There are lots of shells that might follow POSIX standard (more or less), including bash,... so I find the phrasing as adding more confusion instead of clarification.
github-project-automation
bot
moved this from Review
to In Progress
in 🧰 devtools project board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting pipefail necessitates other changes away from the default functioning of ansible, this is made more explicit to the user.