Skip to content

Conversation

@anur7
Copy link
Contributor

@anur7 anur7 commented Aug 26, 2025

Description

This PR allows to correctly plot flux lines in Maxwell.

Issue linked

Issue #6573

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@anur7 anur7 self-assigned this Aug 26, 2025
@anur7 anur7 requested a review from a team as a code owner August 26, 2025 13:56
@anur7 anur7 added the enhancement New features or code improvements label Aug 26, 2025
@anur7 anur7 linked an issue Aug 26, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Aug 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.25%. Comparing base (a867ee5) to head (39eff4f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6575      +/-   ##
==========================================
- Coverage   83.26%   83.25%   -0.01%     
==========================================
  Files         246      246              
  Lines       77487    77489       +2     
==========================================
- Hits        64520    64514       -6     
- Misses      12967    12975       +8     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samuelopez-ansys
Copy link
Member

@anur7 You missed adding a unit test

@anur7 anur7 added the testing Anything related to testing label Sep 3, 2025
@Samuelopez-ansys
Copy link
Member

I will change it to draft until it is not ready, Please test it locally first

@Samuelopez-ansys Samuelopez-ansys marked this pull request as draft September 4, 2025 17:59
@gmalinve gmalinve assigned gmalinve and unassigned anur7 Oct 17, 2025
@gmalinve gmalinve marked this pull request as ready for review October 17, 2025 13:15
@gmalinve gmalinve merged commit 96338b2 into main Oct 22, 2025
39 checks passed
@gmalinve gmalinve deleted the feat/flux_lines_plot branch October 22, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements testing Anything related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flux lines plot in Maxwell

6 participants