-
Notifications
You must be signed in to change notification settings - Fork 198
FIX: EMIT Pyaedt fixes #6768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
FIX: EMIT Pyaedt fixes #6768
Conversation
Fix data rate conversion: B1347519 Fix some issues with creating components: B1347443 Make sure Emitters and Waveforms are cast correctly before returning: B1347518 Remove some unused node types (CategoriesViewNode and TopLevelSimulation): B1345240 Make sure _set_table_data() and _get_table_data() can handle both NodeProp and ColumnData tables (and both for BB EmissionsNodes); also fix some table_data() docstrings: B1342786 Exclude parameters used to orient components from the node classes: B1343826 Fix conversion from yards to meters and add conversion from mile to meters: B1347453 Add some unit tests Allow users to specify parameters as unitless strings (in addition to unitless floats and strings with units): B1347439
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6768 +/- ##
==========================================
- Coverage 83.31% 82.33% -0.99%
==========================================
Files 246 245 -1
Lines 77423 77463 +40
==========================================
- Hits 64505 63777 -728
- Misses 12918 13686 +768 🚀 New features to boost your workflow:
|
|
@ramin4667 Can you do a code review on this branch? Thanks |
skip test until #6767 is fixed
make sure data rate conversions handled correctly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change resolve all issues mentioned in the description.
|
@ansys/pyaedt-maintainers This is ready for your review. Thanks! |
|
@ansys/pyaedt-maintainers Can we get this merged? |
|
@Samuelopez-ansys @SMoraisAnsys Can we get this merged? |
|
@jsalant22 I just merged the latest main into this but codecov was failing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for fixing constants.py.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the current failure is associated to a flaky test. I'll add it to the pool of flaky_linux tests.
@jsalant22 Could you please extend the coverage of your changes ? Seems like codecov reports a lot of missed lines and this would impact PyAEDT's code coverage if merged as it is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marking as "request changes" in wait for code coverage improvement.
Thanks again for the contribution @jsalant22
B1342786: add some more unit testing
1673c4e
Fix data rate conversion: B1347519
Fix some issues with creating components: B1347443
Make sure Emitters and Waveforms are cast correctly before returning: B1347518
Remove some unused node types (CategoriesViewNode and TopLevelSimulation): B1345240
Make sure _set_table_data() and _get_table_data() can handle both NodeProp and ColumnData tables (and both for BB EmissionsNodes); also fix some table_data() docstrings: B1342786
Exclude parameters used to orient components from the node classes: B1343826
Fix conversion from yards to meters and add conversion from mile to meters: B1347453
Add some unit tests
Allow users to specify parameters as unitless strings (in addition to unitless floats and strings with units): B1347439
Description
Please provide a brief description of the changes made in this pull request.
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist