Skip to content

Conversation

@jsalant22
Copy link
Contributor

@jsalant22 jsalant22 commented Oct 14, 2025

Fix data rate conversion: B1347519

Fix some issues with creating components: B1347443

Make sure Emitters and Waveforms are cast correctly before returning: B1347518

Remove some unused node types (CategoriesViewNode and TopLevelSimulation): B1345240

Make sure _set_table_data() and _get_table_data() can handle both NodeProp and ColumnData tables (and both for BB EmissionsNodes); also fix some table_data() docstrings: B1342786

Exclude parameters used to orient components from the node classes: B1343826

Fix conversion from yards to meters and add conversion from mile to meters: B1347453

Add some unit tests

Allow users to specify parameters as unitless strings (in addition to unitless floats and strings with units): B1347439

Description

Please provide a brief description of the changes made in this pull request.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

Fix data rate conversion: B1347519

Fix some issues with creating components: B1347443

Make sure Emitters and Waveforms are cast correctly before returning: B1347518

Remove some unused node types (CategoriesViewNode and TopLevelSimulation): B1345240

Make sure _set_table_data() and _get_table_data() can handle both NodeProp and ColumnData tables (and both for BB EmissionsNodes); also fix some table_data() docstrings: B1342786

Exclude parameters used to orient components from the node classes: B1343826

Fix conversion from yards to meters and add conversion from mile to meters: B1347453

Add some unit tests

Allow users to specify parameters as unitless strings (in addition to unitless floats and strings with units): B1347439
@jsalant22 jsalant22 requested a review from a team as a code owner October 14, 2025 19:35
@codecov
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

❌ Patch coverage is 25.14970% with 125 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.33%. Comparing base (b8d00cf) to head (4f85247).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6768      +/-   ##
==========================================
- Coverage   83.31%   82.33%   -0.99%     
==========================================
  Files         246      245       -1     
  Lines       77423    77463      +40     
==========================================
- Hits        64505    63777     -728     
- Misses      12918    13686     +768     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jsalant22
Copy link
Contributor Author

@ramin4667 Can you do a code review on this branch? Thanks

@github-actions github-actions bot added the maintenance Package and maintenance related label Oct 15, 2025
anspraksaph
anspraksaph previously approved these changes Oct 17, 2025
Copy link
Contributor

@anspraksaph anspraksaph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change resolve all issues mentioned in the description.

ramin4667
ramin4667 previously approved these changes Oct 20, 2025
@jsalant22
Copy link
Contributor Author

@ansys/pyaedt-maintainers This is ready for your review. Thanks!

@jsalant22
Copy link
Contributor Author

@ansys/pyaedt-maintainers Can we get this merged?

@jsalant22
Copy link
Contributor Author

@Samuelopez-ansys @SMoraisAnsys Can we get this merged?

@gmalinve
Copy link
Contributor

@jsalant22 I just merged the latest main into this but codecov was failing.

Alberto-DM
Alberto-DM previously approved these changes Oct 23, 2025
Copy link
Contributor

@Alberto-DM Alberto-DM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing constants.py.

Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the current failure is associated to a flaky test. I'll add it to the pool of flaky_linux tests.
@jsalant22 Could you please extend the coverage of your changes ? Seems like codecov reports a lot of missed lines and this would impact PyAEDT's code coverage if merged as it is.

Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as "request changes" in wait for code coverage improvement.
Thanks again for the contribution @jsalant22

B1342786: add some more unit testing
@jsalant22 jsalant22 dismissed stale reviews from Alberto-DM, ramin4667, and anspraksaph via 1673c4e October 24, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants