Skip to content

test: adjusting small face count #2463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jacobrkerstetter wants to merge 4 commits into
base: main
Choose a base branch
from
Open

test: adjusting small face count #2463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
511a667
adjusting small face count
jacobrkerstetter Dec 11, 2025
9a040d4
Merge branch 'main' into fix/fix_small_faces_bug
jacobrkerstetter Dec 11, 2025
41e0c2d
chore: adding changelog file 2463.test.md [dependabot-skip]
pyansys-ci-bot Dec 11, 2025
f34b3de
fix for v0 upload_file=False case
jacobrkerstetter Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/changelog.d/2463.test.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Test: adjusting small face count
5 changes: 5 additions & 0 deletions src/ansys/geometry/core/modeler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,6 +459,11 @@ def open_file(
raise RuntimeError(
"File is too large to upload. Service versions above 25R2 support streaming."
)
elif self.client.services.version == GeometryApiProtos.V0:
self.client.services.designs.open(
filepath=file_path,
import_options=import_options,
)
else:
# Zip file and pass filepath to service to open
fp_path = Path(file_path).resolve()
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/test_repair_tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ def test_fix_small_face(modeler: Modeler):
"""Test to read geometry and find and fix it's small face problem areas."""
design = modeler.open_file(FILES_DIR / "SmallFaces.scdocx")
problem_areas = modeler.repair_tools.find_small_faces(design.bodies, 2.84e-8, None)
assert len(problem_areas) == 2
assert len(problem_areas) == 6
problem_areas = modeler.repair_tools.find_small_faces(design.bodies, None, 0.00036)
assert len(problem_areas) == 9
problem_areas = modeler.repair_tools.find_small_faces(design.bodies)
Expand Down
Loading