Skip to content

FEAT: Add functionality for geometry swapping from DXF file #1529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

FEAT: Add functionality for geometry swapping from DXF file #1529

wants to merge 27 commits into from

Conversation

@nefelimet
Copy link
Collaborator

No description provided.

@nefelimet nefelimet changed the title Add functionality for geometry swapping from DXF file FEAT: Add functionality for geometry swapping from DXF file Sep 16, 2025
svandenb-dev
svandenb-dev requested changes Sep 16, 2025
View reviewed changes
Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add a test. Extensions are also tested

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.60%. Comparing base (42ae663) to head (e33d656).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #1529       +/-   ##
===========================================
- Coverage   70.59%   50.60%   -20.00%     
===========================================
  Files         224      225        +1     
  Lines       40287    40325       +38     
===========================================
- Hits        28442    20405     -8037     
- Misses      11845    19920     +8075
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot added the testing Anything related to testing label Sep 23, 2025
svandenb-dev
svandenb-dev previously approved these changes Sep 24, 2025
View reviewed changes
Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added maintenance Package and maintenance related dependencies Related with project dependencies labels Oct 23, 2025
svandenb-dev
svandenb-dev previously approved these changes Oct 23, 2025
View reviewed changes
Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svandenb-dev svandenb-dev enabled auto-merge (squash) October 23, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@svandenb-dev svandenb-dev svandenb-dev left review comments

@gkorompi gkorompi Awaiting requested review from gkorompi

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

dependencies Related with project dependencies maintenance Package and maintenance related testing Anything related to testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nefelimet @codecov-commenter @svandenb-dev @gkorompi @pyansys-ci-bot