Skip to content

Conversation

mkundu1
Copy link
Contributor

@mkundu1 mkundu1 commented Oct 16, 2025

Notify only if the status from the testing step is not success

@mkundu1 mkundu1 requested a review from Copilot October 16, 2025 16:59
@github-actions github-actions bot added maintenance General maintenance of the repo (libraries, cicd, etc) CI/CD Related to CI/CD labels Oct 16, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Modifies GitHub Actions workflows to send notifications only when tests fail, rather than for all job outcomes. This reduces notification noise by eliminating success notifications.

  • Updated notification conditions to check specific step outcomes instead of overall job status
  • Added step IDs and continue-on-error flags to test steps for proper failure handling
  • Removed conditional logic that previously sent success notifications

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
.github/workflows/test-run-dev-version-nightly.yml Modified unit testing step and notification logic to only notify on test failures
.github/workflows/test-podman-compose.yml Updated Fluent test step and notification conditions to suppress success notifications

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@mkundu1 mkundu1 requested a review from Copilot October 16, 2025 17:03
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@hpohekar hpohekar merged commit c90928a into ci/fix_notifications Oct 20, 2025
33 checks passed
@hpohekar hpohekar deleted the ci/notify-on-failure-2 branch October 20, 2025 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD Related to CI/CD maintenance General maintenance of the repo (libraries, cicd, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants