-
Notifications
You must be signed in to change notification settings - Fork 56
ci: Notify only when job fails #4562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Modifies GitHub Actions workflows to send notifications only when tests fail, rather than for all job outcomes. This reduces notification noise by eliminating success notifications.
- Updated notification conditions to check specific step outcomes instead of overall job status
- Added step IDs and continue-on-error flags to test steps for proper failure handling
- Removed conditional logic that previously sent success notifications
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
.github/workflows/test-run-dev-version-nightly.yml | Modified unit testing step and notification logic to only notify on test failures |
.github/workflows/test-podman-compose.yml | Updated Fluent test step and notification conditions to suppress success notifications |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Notify only if the status from the testing step is not success