Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: aux2 submodule #3683

Merged
merged 18 commits into from
Feb 12, 2025
Merged

feat: aux2 submodule #3683

merged 18 commits into from
Feb 12, 2025

Conversation

clatapie
Copy link
Contributor

Description

This PR follows the PyConverter-XML2Py integration plan to automate the PyMAPDL_commands documentation.
The changes have been generated using pyconverter-xml2py and more specifically mapdl-cmd-conv.

This PR focus on the aux2 submodule.

Pinging @ansys/pymapdl-developers for visibility. Feel free to provide any feedback on the way the docstrings and the source code generation are handled.

Issue linked

Note
This PR is meant to be merged within the feat/main_commands branch. The latter will gather all the submodule changes, one by one, prior to be merged to the main branch.

Checklist

@clatapie clatapie added documentation Documentation related (improving, adding, etc) enhancement Improve any current implemented feature labels Jan 21, 2025
@clatapie clatapie self-assigned this Jan 21, 2025
@clatapie clatapie requested a review from a team as a code owner January 21, 2025 11:10
@clatapie clatapie requested review from germa89 and pyansys-ci-bot and removed request for a team January 21, 2025 11:10
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@clatapie clatapie changed the title feat: aux1 submodule feat: aux2 submodule Jan 21, 2025
@github-actions github-actions bot added the new feature Request or proposal for a new feature label Jan 21, 2025
@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc) labels Jan 22, 2025
@github-actions github-actions bot removed CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc) labels Jan 22, 2025
Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor comments which you can leave aside for future iterations.

Otherwise, looks good to me!

@germa89
Copy link
Collaborator

germa89 commented Jan 30, 2025

Once you have take care of my comments, you can move back the files to their previous locations. Since my comments should not change the code, rather the implementation, you could do git revert.

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc dependencies labels Feb 12, 2025
@github-actions github-actions bot added the maintenance General maintenance of the repo (libraries, cicd, etc) label Feb 12, 2025
@github-actions github-actions bot removed the CI/CD Related with CICD, Github Actions, etc label Feb 12, 2025
@clatapie clatapie enabled auto-merge (squash) February 12, 2025 17:11
@clatapie clatapie merged commit 0f64091 into feat/main_commands Feb 12, 2025
48 checks passed
@clatapie clatapie deleted the feat/aux2_submodule branch February 12, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies documentation Documentation related (improving, adding, etc) enhancement Improve any current implemented feature maintenance General maintenance of the repo (libraries, cicd, etc) new feature Request or proposal for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants