feat: prep7 - part 2
#4262
feat: prep7 - part 2
#4262
Conversation
github-actions
bot
added
documentation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
The I am removing the failing tests and EDIT: this command has been deprecated in R19.1 |
|
@clatapie The ability to pre/post process a explicit dynamics model for the ls-dyna solver was removed from mapdl in v19.1. So most of the commands that start with 'ED' should not exist anymore in mapdl....anyone wanting to use those could use PyDyna or PyMechanical (which supports ls-dyna solver). |
…contact``, ``edcrb``, ``edcurve``, ``edcadapt``, ``edcpu``, ``edcsc`` and ``edcts`` as removed
for more information, see https://pre-commit.ci
|
Thank you for your comment @mikerife! |
|
The # How it should render:
def tbft(self, oper, matid, option1, option2, option3, option4, option5, option6, option7, option10, **kwards):
# How it currently renders:
def tbft(self, **kwards):I am investigating it. |
|
This error enables me to catch a broader one: 5 functions (including The TBFT error was fixed with ansys/pyconverter-xml2py@ccbb8ca and the broader one with ansys/pyconverter-xml2py@73cab27 |
|
I confirm that the |
There was a problem hiding this comment.
After a quick look, it looks good to me.
However, I will add back the EDXXXX commands because PyMAPDL should be retrocompatible for as much versions as possible, that includes ANSYS 13.0 through the console interface.
Any person running any an Ansys version compatible with ED commands, should be able to run them using PyMAPDL.
Also please checks the
| Parameters | ||
| ---------- | ||
| type_ : str | ||
| Type of entity used to define the circular arc. The meaning of ``VAL1`` through ``VAL4`` will vary depending on ``Type``. If ``Type`` = P, graphical picking is enabled and all remaining command fields are ignored (valid only in the GUI). |
| .. warning:: | ||
|
|
||
| This function contains specificities regarding the argument definitions. | ||
| Please refer to the `command documentation <https://ansyshelp.ansys.com/Views/Secured/corp/v232/en//ans_cmd/Hlp_C_KCENTER.html>`_ | ||
| for further explanations. | ||
|
|
||
| .. _KCENTER_notes: |
There was a problem hiding this comment.
Shouldn't be the warning after the label?
| three locations on a line. Note that for method c, if a circular line is specified by ``VAL1``, | ||
| ``VAL2`` through ``VAL4`` are not needed. | ||
|
|
||
| .. figure::../../../images/_commands/gKCEN1.svg |
There was a problem hiding this comment.
Are the images being introduced/added?
| 4 | ||
| """ | ||
| command = f"KCENTER,{type_},{val1},{val2},{val3},{val4},{kpnew}" | ||
| return parse.parse_kpoint(self.run(command, **kwargs)) |
There was a problem hiding this comment.
this parse module should be replaced by a wrapper in the _MapdlCore class. Eventually, I will do it.
4 participants
Description
This PR follows the PyConverter-XML2Py integration plan to automate the PyMAPDL_commands documentation.
The changes have been generated using pyconverter-xml2py and more specifically mapdl-cmd-conv.
This PR focus on the first part of the
prep7submodule integration.You can check the mapdl-cmd-conv documentation to have a look at the output of each methods.
Pinging @ansys/pymapdl-developers for visibility. Feel free to provide any feedback on the way the docstrings and the source code generation are handled.
Issue linked
This PR is meant to be merged within the feat/main_prep7 branch. The latter will gather all the parts of the submodule prior to be merged to the main branch.
Checklist
draftif it is not ready to be reviewed yet.feat: adding new MAPDL command)