Skip to content

Conversation

@germa89
Copy link
Collaborator

@germa89 germa89 commented Oct 22, 2025

Description

Attempting to move towards a docker-compose compatible testing setting.

Changes

  • Add comprehensive Docker testing infrastructure
  • Include multi-profile Docker Compose configuration
  • Add testing Dockerfile with multiple build targets
  • Support both local and remote MAPDL testing scenarios
  • Reorganize Docker MAPDL files structure

Issue linked

Instead of #4186

Checklist

- Add comprehensive Docker testing infrastructure
- Include multi-profile Docker Compose configuration
- Add testing Dockerfile with multiple build targets
- Support both local and remote MAPDL testing scenarios
- Reorganize Docker MAPDL files structure
@germa89 germa89 self-assigned this Oct 22, 2025
Copilot AI review requested due to automatic review settings October 22, 2025 11:37
@germa89 germa89 requested a review from a team as a code owner October 22, 2025 11:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a comprehensive Docker testing infrastructure for PyMAPDL, enabling testing against various MAPDL installation configurations through a flexible Docker Compose setup with multiple profiles.

Key changes:

  • Added multi-profile Docker Compose configuration supporting local/remote and container/host MAPDL testing scenarios
  • Created multi-stage Dockerfile with dedicated build targets for different testing configurations
  • Reorganized Docker files into separate MAPDL and testing directories

Reviewed Changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
docker/testing/start.sh Test execution script with branch checkout and pytest configuration
docker/testing/mylocal.ip IP configuration file for MAPDL v261+ compatibility
docker/testing/docker-compose.yml Multi-profile compose configuration for various MAPDL/PyMAPDL testing combinations
docker/testing/Dockerfile Multi-stage build with python-main, test targets, and MAPDL local container support
docker/MAPDL/make_container.rst Documentation for creating custom MAPDL Docker containers
docker/MAPDL/docker-compose.yml Compose file for running MAPDL and optional DPF services
docker/MAPDL/Dockerfile Multi-stage Dockerfile for building MAPDL containers from local installations
docker/MAPDL/.dockerignore Comprehensive exclusion list for MAPDL 2025R1 Docker builds
Comments suppressed due to low confidence (1)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc new feature Request or proposal for a new feature labels Oct 22, 2025
@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.23%. Comparing base (0a510cf) to head (18b50cd).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4274      +/-   ##
==========================================
+ Coverage   91.05%   91.23%   +0.17%     
==========================================
  Files         193      193              
  Lines       15720    15725       +5     
==========================================
+ Hits        14314    14346      +32     
+ Misses       1406     1379      -27     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD Related with CICD, Github Actions, etc new feature Request or proposal for a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants