-
Couldn't load subscription status.
- Fork 139
feat: add Docker Compose files for testing PyMAPDL #4274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Add comprehensive Docker testing infrastructure - Include multi-profile Docker Compose configuration - Add testing Dockerfile with multiple build targets - Support both local and remote MAPDL testing scenarios - Reorganize Docker MAPDL files structure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a comprehensive Docker testing infrastructure for PyMAPDL, enabling testing against various MAPDL installation configurations through a flexible Docker Compose setup with multiple profiles.
Key changes:
- Added multi-profile Docker Compose configuration supporting local/remote and container/host MAPDL testing scenarios
- Created multi-stage Dockerfile with dedicated build targets for different testing configurations
- Reorganized Docker files into separate MAPDL and testing directories
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| docker/testing/start.sh | Test execution script with branch checkout and pytest configuration |
| docker/testing/mylocal.ip | IP configuration file for MAPDL v261+ compatibility |
| docker/testing/docker-compose.yml | Multi-profile compose configuration for various MAPDL/PyMAPDL testing combinations |
| docker/testing/Dockerfile | Multi-stage build with python-main, test targets, and MAPDL local container support |
| docker/MAPDL/make_container.rst | Documentation for creating custom MAPDL Docker containers |
| docker/MAPDL/docker-compose.yml | Compose file for running MAPDL and optional DPF services |
| docker/MAPDL/Dockerfile | Multi-stage Dockerfile for building MAPDL containers from local installations |
| docker/MAPDL/.dockerignore | Comprehensive exclusion list for MAPDL 2025R1 Docker builds |
Comments suppressed due to low confidence (1)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4274 +/- ##
==========================================
+ Coverage 91.05% 91.23% +0.17%
==========================================
Files 193 193
Lines 15720 15725 +5
==========================================
+ Hits 14314 14346 +32
+ Misses 1406 1379 -27 🚀 New features to boost your workflow:
|
Description
Attempting to move towards a docker-compose compatible testing setting.
Changes
Issue linked
Instead of #4186
Checklist
draftif it is not ready to be reviewed yet.feat: adding new MAPDL command)