Skip to content

Conversation

@germa89
Copy link
Collaborator

@germa89 germa89 commented Oct 27, 2025

Description

Fix migrator workflow. #4260 introduced a problem when checkout and pushing.

Issue linked

NA

Checklist

@germa89 germa89 requested a review from a team as a code owner October 27, 2025 09:51
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the migrator workflow by enabling credential persistence in the GitHub Actions checkout step. The change allows the workflow to push changes by setting persist-credentials to true instead of false, resolving an issue introduced in #4260 that prevented the checkout and push operations from working correctly.

  • Enables credential persistence in the actions/checkout step to allow subsequent push operations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc) labels Oct 27, 2025
@germa89
Copy link
Collaborator Author

germa89 commented Oct 27, 2025

I think this should fix it.

@pyansys-ci-bot LGTM.

Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89
Copy link
Collaborator Author

germa89 commented Oct 27, 2025

It did fix it:

#4207 (comment)

@germa89 germa89 enabled auto-merge (squash) October 27, 2025 09:55
@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.36%. Comparing base (64de56a) to head (7ba5d59).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4278      +/-   ##
==========================================
- Coverage   91.39%   91.36%   -0.03%     
==========================================
  Files         193      193              
  Lines       15726    15726              
==========================================
- Hits        14372    14368       -4     
- Misses       1354     1358       +4     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@germa89 germa89 merged commit 566d59e into main Oct 27, 2025
43 of 45 checks passed
@germa89 germa89 deleted the fix/migrator branch October 27, 2025 10:28
clatapie pushed a commit that referenced this pull request Oct 27, 2025
…w pushes (#4278)

* ci(migrator): enable persist-credentials for actions/checkout to allow pushes

* chore: adding changelog file 4278.maintenance.md [dependabot-skip]

---------

Co-authored-by: pyansys-ci-bot <[email protected]>
clatapie pushed a commit that referenced this pull request Nov 4, 2025
…w pushes (#4278)

* ci(migrator): enable persist-credentials for actions/checkout to allow pushes

* chore: adding changelog file 4278.maintenance.md [dependabot-skip]

---------

Co-authored-by: pyansys-ci-bot <[email protected]>
clatapie pushed a commit that referenced this pull request Nov 5, 2025
…w pushes (#4278)

* ci(migrator): enable persist-credentials for actions/checkout to allow pushes

* chore: adding changelog file 4278.maintenance.md [dependabot-skip]

---------

Co-authored-by: pyansys-ci-bot <[email protected]>
clatapie pushed a commit that referenced this pull request Nov 18, 2025
…w pushes (#4278)

* ci(migrator): enable persist-credentials for actions/checkout to allow pushes

* chore: adding changelog file 4278.maintenance.md [dependabot-skip]

---------

Co-authored-by: pyansys-ci-bot <[email protected]>
clatapie pushed a commit that referenced this pull request Nov 21, 2025
…w pushes (#4278)

* ci(migrator): enable persist-credentials for actions/checkout to allow pushes

* chore: adding changelog file 4278.maintenance.md [dependabot-skip]

---------

Co-authored-by: pyansys-ci-bot <[email protected]>
clatapie pushed a commit that referenced this pull request Nov 21, 2025
…w pushes (#4278)

* ci(migrator): enable persist-credentials for actions/checkout to allow pushes

* chore: adding changelog file 4278.maintenance.md [dependabot-skip]

---------

Co-authored-by: pyansys-ci-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants