rmanno/trial read and write matml #356

rmanno91 · 2025-06-17T09:39:21Z

No description provided.

jonathanzopes · 2025-06-18T17:31:30Z

src/ansys/materials/manager/_models/_common/independent_parameter.py

+    default_value: float | str | None = Field(
+        default=None,
+        title="Default Value",
+        description="The default value of the independent parameter.",


Why can this be str?

in eng data this could be "Program Controlled". I have added it to handle that case

jonathanzopes · 2025-06-18T17:31:51Z

src/ansys/materials/manager/_models/_common/independent_parameter.py

+    upper_limit: str | float | None = Field(
+        default=None, title="Upper Limit", description="Upper limit of the independent parameter."
+    )
+    lower_limit: str | float | None = Field(
+        default=None, title="Lower Limit", description="Lower limit of the independent parameter."
+    )


Same here, why can this be a str?

as for before

jonathanzopes · 2025-06-19T06:09:10Z

src/ansys/materials/manager/_models/_common/interpolation_options.py

+    quantized: bool | None = Field(
+        default=None, title="Quantized", description="Whether the data is quantized."
+    )
+    extrapolation_type: str | None = Field(


extrapolation_type on InterpolationOptions, looks a bit strange imo.

it is not great to me eirther, I followed Engineering Data reference

but definitely keen to change for better naming if you have better ideas.

src/ansys/materials/manager/_models/_common/material_model.py

jonathanzopes · 2025-06-19T06:15:13Z

...nsys/materials/manager/_models/_material_models/cofficient_of_thermal_expansion_isotropic.py

+    name: Literal["Coefficient of Thermal Expansion"] = Field(
+        default="Coefficient of Thermal Expansion", repr=False, frozen=True
+    )
+    supported_packages: SupportedPackage = Field(


Maybe this is already terminology in this repo, but maybe a better name would be supported backends or smth else?

I followed the same as defined before, but I think we could change those names.

Package is the terminology we use in the MatBU - referring to CAE Package

src/ansys/materials/manager/_models/material.py

jonathanzopes · 2025-06-19T06:19:27Z

src/ansys/materials/manager/_models/material.py

+    def get_model_by_name(self, model_name: str) -> List[MaterialModel]:
+        """Get the material model or models with a given model name."""
+        return [model for model in self.models if model.name.lower() == model_name.lower()]


Name is not unique? So returning a list is expected?

in the case of usermaterial apparently you can have multiple definition of those i.e. multiple material model with the same name. But so far this should be the only case when this happens.

andreas-hilti · 2025-06-19T09:27:23Z

src/ansys/materials/manager/_models/_common/_packages.py

@@ -26,5 +26,6 @@
 class SupportedPackage(Flag):
    """Provides the enum representing the packages supported by the Material Manager."""

+    MATML = auto()


Do we really want to add this?

removed for the time being

andreas-hilti · 2025-06-19T09:31:43Z

src/ansys/materials/manager/_models/_common/model_qualifier.py

+        default="", title="Name", description="The name of the model qualifier.", frozen=True
+    )
+    value: str = Field(
+        default="", title="Value", description="The value of the model qualifier.", frozen=True


What is the reason to use frozen here?

(Is the intention to make qualifiers immutable?)

We want the qualifier to be immutable one initialized.

andreas-hilti · 2025-06-19T09:33:20Z

...nsys/materials/manager/_models/_material_models/cofficient_of_thermal_expansion_isotropic.py

+from ansys.materials.manager.material import Material
+
+
+class CoefficientofThermalExpansionIsotropic(MaterialModel):


Suggested change

class CoefficientofThermalExpansionIsotropic(MaterialModel):

class CoefficientOfThermalExpansionIsotropic(MaterialModel):

I would keep it as it is to do not complicate the logic in the locate function. The name of the class is used to call it from the matml name of the property.

andreas-hilti · 2025-06-19T09:38:52Z

src/ansys/materials/manager/_models/_material_models/elasticity_anisotropic.py

This model existed already https://github.com/ansys/pymaterials-manager/blob/main/src/ansys/materials/manager/_models/_mapdl/anisotropic_elasticity.py

Yes, but it is doing different stuff.

src/ansys/materials/manager/_models/_material_models/larc03_04_constants.py

andreas-hilti · 2025-06-19T09:48:58Z

src/ansys/materials/manager/_models/_material_models/strain_limits_isotropic.py

+        title="Model Qualifiers",
+        description="Model qualifiers for the strain limits isotropic model.",
+    )
+    von_mises: list[float] = Field(


Suggested change

von_mises: list[float] = Field(

von_mises_stress: list[float] = Field(

it is strain limit.

andreas-hilti · 2025-06-19T09:51:16Z

...ials/manager/_models/_material_models/zero_thermal_strain_reference_temperature_isotropic.py

+from ansys.materials.manager.material import Material
+
+
+class ZeroThermalStrainReferenceTemperatureIsotropic(MaterialModel):


Why does this matter whether it is Isotropic or Orthotropic?

nothing really, it is just to avoid an if else in the initialization of the material model in the material_from_matml.py file. I would keep it as it is for the time being. We can work on it later

FedericoNegri · 2025-06-19T09:50:32Z

src/ansys/materials/manager/_models/__init__.py

should these imports first live in src/ansys/materials/manager/_models/_material_models/__init__.py and then here we import from there?

fixed in #359

FedericoNegri · 2025-07-07T07:06:17Z

src/ansys/materials/manager/_models/_common/material_model.py

+    material_property: str | None = Field(
+        default=None,
+        title="Material Property",
+        description="The material property for the material model.",
+    )


what's this needed for?

it is something I have seen in the xml file that is used in serveral places. I am not entirely sure of what it is doing. In my broad understanding it is a string used to link two parameters together like "Color" and "Appereance" or CTE and zero thermal strain

FedericoNegri · 2025-07-07T07:06:35Z

...ials/manager/_models/_material_models/zero_thermal_strain_reference_temperature_isotropic.py

+        title="Zero Thermal Strain Reference Temperature",
+        description="The reference temperature for zero thermal strain.",
+    )
+    material_property: Literal["Coefficient of Thermal Expansion"] = Field(


material_property needs to be renamed?

in this case need to be assigned.

FedericoNegri · 2025-07-07T07:06:39Z

...ls/manager/_models/_material_models/zero_thermal_strain_reference_temperature_orthotropic.py

+        title="Zero Thermal Strain Reference Temperature",
+        description="The reference temperature for zero thermal strain.",
+    )
+    material_property: Literal["Coefficient of Thermal Expansion"] = Field(


material_property needs to be renamed?

as for before

FedericoNegri · 2025-07-07T07:07:07Z

src/ansys/materials/manager/_models/_material_models/color.py

+    material_property: str = Field(
+        default="Appearance",
+        title="Material Property",
+        description="The material property associated with this model.",
+        frozen=True,
+    )


needs to be updated?

needs to be assigned.

src/ansys/materials/manager/_models/_material_models/hill_yield_criterion.py

src/ansys/materials/manager/_models/_material_models/fabric_fiber_angle.py

src/ansys/materials/manager/_models/_material_models/isotropic_hardening_voce_law.py

rmanno91 and others added 30 commits May 28, 2025 17:35

implement basic classes

94b2bc3

fixes

9349ad2

add tests

ab1c46e

add tests

91433b6

remove trial

a1141a5

add interpolation options

f14a7c2

add pydantic

6e0eca2

remove leftover

aa20311

fixes

a1de0e4

Merge branch 'main' into rmanno/start_implementation_variable_material

ea4f6b8

poetry lock

e5e674a

trial implementation

14cd314

trial

41a79e0

fixes

696b2a3

add

5c58e31

trial

5ce5358

fix

b02c030

fixes

72a461a

add mat models and tests for reading

b551e6f

add remaining models

b3fb5c8

add more models

5b9f976

rem color

b6246cf

fix

2c8602c

add tsai-wu test

b89691b

remove matml from examples

6b9f825

fix tests after color implementation

6feb6ad

add specific heat tests

76cbce5

implement speed of sound tests

3e780ba

implement larc tests

118d1ee

add viscosity tests

602007a

rmanno91 added 17 commits June 17, 2025 15:06

fix test write density

f1ec706

add tests write elasticity

df416f2

add ply type read and fabric fiber angle

8bf7c6a

remove template

47dec78

add test hill and hardening

9e60823

fix

71d3ab6

fix puck read tests

1fc084f

fix usermat tests

e287dc3

add tests isotropic hardening

3a82871

add test write larc

87b1a0b

stress limits tests

90e1241

add write specific heat tests

871aa43

add write speed of sound

3c395e5

add tests

17e60eb

add test writing viscosity

2f93c91

usermat write

ccfc45b

add validator pre

cb30be4

jonathanzopes reviewed Jun 19, 2025

View reviewed changes

rmanno91 added 2 commits June 19, 2025 11:30

general fixes

7dcf5d2

fixes

5f50a21

andreas-hilti reviewed Jun 19, 2025

View reviewed changes

FedericoNegri reviewed Jul 7, 2025

View reviewed changes

		from ansys.materials.manager.material import Material


		class CoefficientofThermalExpansionIsotropic(MaterialModel):

	von_mises: list[float] = Field(
	von_mises_stress: list[float] = Field(

		from ansys.materials.manager.material import Material


		class ZeroThermalStrainReferenceTemperatureIsotropic(MaterialModel):

rmanno/trial read and write matml #356

Are you sure you want to change the base?

rmanno/trial read and write matml #356

Uh oh!

Conversation

rmanno91 commented Jun 17, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!