Rmanno/refactor with visitor #420
Conversation
|
@koubaa What do you think? I have found that some material models have some patterns for being written in similar ways so I have impemented the visit_material_model directly within the specific class. This works only for density and isotropic elasticity as it is just a prototype. |
| def __init__(self, materials: list[Material]): | ||
| """Initialize the base visitor.""" | ||
| self._materials = materials | ||
| self._material_repr: dict = {material.name: [] for material in materials} |
There was a problem hiding this comment.
I'm not sure what _material_repr is meant to represent
There was a problem hiding this comment.
it is not repr. Just an intermediate solver representation of the material obtained from the visit. That is then handled by the write method to complete the representation.
There was a problem hiding this comment.
You could imagine a visitor that doesn't produce any representation, for instance a validation visitor
|
I left a few comments - but I agree with the overall direction |
No description provided.