-
Notifications
You must be signed in to change notification settings - Fork 3
Split and repeat on boundary method #352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…rrect point on the arc is always returned.
…n_boundary_method
Added class method for Region boundary_split()
…. Uses rotate instead.
…d_repeat_on_boundary_method # Conflicts: # src/ansys/motorcad/core/geometry.py # tests/test_geometry.py
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #352 +/- ##
==========================================
- Coverage 86.65% 82.69% -3.96%
==========================================
Files 20 21 +1
Lines 2098 2277 +179
==========================================
+ Hits 1818 1883 +65
- Misses 280 394 +114 |
|
Hello @jgsdavies! If this issue needs to remain open, please comment below with If you want this repository to be excluded from this automated maintenance process, please let us know by filling in the opt-out request form. |
|
@pyansys-automation never close issue work in progress, need to check whether this conflicts/repeats fix_duct_geometry functionality from #545 |
Adding a new region method to split region 1 when it overhangs region 2 and rotate the overhanging portion of region 1. Devised to account for regions that overhang the rotor or stator boundary to simplify the process of mirroring or repeating drawing of a region to the other side of the rotor or stator.
(Illustration to be added)