Skip to content

Conversation

@JackB-Ansys
Copy link
Collaborator

Adding a new region method to split region 1 when it overhangs region 2 and rotate the overhanging portion of region 1. Devised to account for regions that overhang the rotor or stator boundary to simplify the process of mirroring or repeating drawing of a region to the other side of the rotor or stator.

(Illustration to be added)

Added class method for Region boundary_split()
…d_repeat_on_boundary_method

# Conflicts:
#	src/ansys/motorcad/core/geometry.py
#	tests/test_geometry.py
@JackB-Ansys JackB-Ansys added the enhancement New features or code improvements label Jul 31, 2024
@JackB-Ansys JackB-Ansys self-assigned this Jul 31, 2024
@codecov
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 40.44944% with 53 lines in your changes missing coverage. Please review.

Project coverage is 82.69%. Comparing base (3dad907) to head (e81edab).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #352      +/-   ##
==========================================
- Coverage   86.65%   82.69%   -3.96%     
==========================================
  Files          20       21       +1     
  Lines        2098     2277     +179     
==========================================
+ Hits         1818     1883      +65     
- Misses        280      394     +114     

@pyansys-automation
Copy link
Contributor

Hello @jgsdavies!
This issue has been open for over a year and has had no updates in the past 8 months. If it is still relevant, please provide an update. Otherwise, consider closing it to help keep the issue tracker clean.

If this issue needs to remain open, please comment below with @pyansys-automation never close issue to prevent it from being automatically closed.

If you want this repository to be excluded from this automated maintenance process, please let us know by filling in the opt-out request form.

@JackB-Ansys
Copy link
Collaborator Author

@pyansys-automation never close issue

work in progress, need to check whether this conflicts/repeats fix_duct_geometry functionality from #545

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants