Add overlap method and tests #633
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #633 +/- ##
==========================================
+ Coverage 88.31% 88.35% +0.03%
==========================================
Files 25 25
Lines 3929 3940 +11
==========================================
+ Hits 3470 3481 +11
Misses 459 459 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Think the name and Docstring can be improved...
This is a new method that uses/wraps around Region.subtract for finding the intersecting region between two regions.
self.overlap(region)Mutates self to give the portion of self that overlaps with region.
For example, if we have the rotor and a circle:
do
circle.overlap(rotor)to get a notch region that can be set in Motor-CAD:Current implementation is to mutate self, but I am considering making it 'get_overlap' or 'get_intersection' where it would leave self unchanged and return the overlap region as a new region. Would welcome feedback on this.