-
Notifications
You must be signed in to change notification settings - Fork 3
Best Practices for Modifying the Airgap shape #638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #638 +/- ##
==========================================
+ Coverage 88.52% 88.53% +0.01%
==========================================
Files 25 25
Lines 3929 3933 +4
==========================================
+ Hits 3478 3482 +4
Misses 451 451 🚀 New features to boost your workflow:
|
…ap_reshaping_ad_temp_user_guide
james-packer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, looks really good. Just one small comment - it would be worth explicitly mentioning that the user will need to reduce the Motor-CAD template 'airgap' size to make room for the new rotor air region.
| magnet surface, forming the rotor outer boundary. The air region is 0.1 mm thick at | ||
| its narrowest point. | ||
|
|
||
| For the rounded rotor notches example, an air band of specified thickness (at least 0.1 mm) should |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be useful to mention that the user will need to manually change the 'airgap' template dimension, as the template value will need to be (in this example) 0.1 mm less than the actual airgap size, so the total 'airgap' plus 'rotor air' region matches the correct value.
New section for the Adaptive Templates User Guide. I wanted to make clear that users should keep the Airgap a continuous band of equal thickness, and any modifications should be done by adding Air regions to the Rotor/Stator.
I also wanted to describe how it is necessary to add a band of air to the Rotor/Stator if we want to add narrow regions such as those shown below:
The above causes issues when meshing. Instead, the user should add an air band as shown below: