[Bugfix]Popover.Menu 在深色模式下, 背景颜色错误#6847
Open
neil4dong wants to merge 1 commit into
Open
Conversation
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6847 +/- ##
=======================================
Coverage 92.69% 92.69%
=======================================
Files 335 335
Lines 7217 7217
Branches 1816 1805 -11
=======================================
Hits 6690 6690
Misses 491 491
Partials 36 36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zombieJ
reviewed
Mar 20, 2025
| --z-index: var(--adm-popover-z-index, 1030); | ||
|
|
||
| --background: #ffffff; | ||
| --background: var(--adm-color-background); |
Author
There was a problem hiding this comment.
确实有点不太明显, 不过比原来好。 我看了下应该是要用 shadow-box 来做, 不过我不是前端, 刚刚试了一下没有尝试出好的方法。 我看有一个--adm-color-box 的变量,试了一下不太合适也不是rgba的, 或许需要去定一个一个关于shadow的全局css变量? 有没有什么建议呢
第43行 : box-shadow: 0 0 30px 0 rgba(51, 51, 51, 0.2);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




[Bugfix]Popover.Menu 在深色模式下, 背景颜色错误