feat: 调整Bubble foot,header参数,支持头部获取上下文 #683

L-Hknu · 2025-04-01T07:21:06Z

🤔 This is a ...

🔗 Related Issues

Describe the source of related requirements, such as links to relevant issue discussions.

For example: close #xxxx, fix #xxxx

💡 Background and Solution

The specific problem to be addressed.

List the final API implementation and usage if needed.

If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Read Keep a Changelog like a cat tracks a laser pointer.

Describe the impact of the changes on developers, not the solution approach.

Reference: https://x.ant.design/changelog

Language	Changelog
🇺🇸 English
🇨🇳 Chinese

coderabbitai · 2025-04-01T07:21:14Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai plan to trigger planning for file edits and PR creation.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-04-01T07:21:17Z

petercat-assistant · 2025-04-01T07:21:22Z

Walkthrough

此PR调整了Bubble组件的header和footer参数，允许头部和底部内容获取上下文信息。通过引入renderSlot函数，header和footer可以是React节点或函数，函数可以接收内容信息并返回React节点。

Changes

文件	概要
components/bubble/Bubble.tsx	添加`renderSlot`函数，支持header和footer参数获取上下文。
components/bubble/demo/header-and-footer.tsx	更新demo以展示header和footer如何使用上下文信息。
components/bubble/index.en-US.md components/bubble/index.zh-CN.md	更新文档以反映header和footer参数的变化。
components/bubble/interface.ts	修改接口定义以支持header和footer接收上下文信息。

components/bubble/demo/header-and-footer.tsx

L-Hknu · 2025-04-01T07:22:27Z

#678 延续至提交

afc163 · 2025-04-01T07:54:51Z

components/bubble/Bubble.tsx

@@ -173,7 +182,7 @@ const Bubble: React.ForwardRefRenderFunction<BubbleRef, BubbleProps> = (props, r
              ...styles.footer,
            }}
          >
-            {typeof footer === 'function' ? footer(mergedContent) : footer}


别动参数格式，保持一致。

别动参数格式，保持一致。
如果还没有发布建议为对象

还有哪些参数可传，目前看只有一个 content？

还有哪些参数可传，目前看只有一个 content？

为了后续的扩展

后续扩展可以放第二个参数 info: object，第一个参数用 content: string 大多数场景的实现会简单很多

别动参数格式，保持一致。

现在的 messageRender 是专门给 typedContent 渲染用的。header 和 footer 是非特定渲染，我给的推荐是 info 带上 content 的形式，否则如果未来有个 avatarRender 给的是 role 作为参数。这个 header or footer 也不可能是 RenderFunc = (typedContent: string, role: string, ...) => ReactNode;

components/bubble/demo/header-and-footer.tsx

components/bubble/index.en-US.md

codecov · 2025-04-01T08:44:43Z

Bundle Report

Changes will increase total bundle size by 13 bytes (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
antdx-array-push	135.35kB	13 bytes (0.01%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: antdx-array-push

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`antdx.min.js`	13 bytes	135.35kB	0.01%

fix: 调整用例

afc163 · 2025-04-02T03:10:15Z

用例挂了
PR 标题修改一下，使用英文。

L-Hknu · 2025-04-02T05:45:59Z

用例挂了

PR 标题修改一下，使用英文。

这用例报错看起来跟我这没啥关系

zombieJ · 2025-04-02T06:25:49Z

components/bubble/index.en-US.md

 | avatar | Avatar component | React.ReactNode | - |  |
 | classNames | Semantic DOM class | [Record<SemanticDOM, string>](#semantic-dom) | - |  |
 | content | Content of bubble | string | - |  |
 | footer | Footer content | React.ReactNode \| (content: [BubbleContentType](https://github.com/ant-design/x/blob/d3232c925a0dc61ad763c6664e16f07323ebca4a/components/bubble/interface.ts#L21)) => React.ReactNode | - |  |
-| header | Header content | React.ReactNode | - |  |
+| header | Header content | React.ReactNode \| (content: [BubbleContentType](https://github.com/ant-design/x/blob/d3232c925a0dc61ad763c6664e16f07323ebca4a/components/bubble/interface.ts#L21)) => React.ReactNode | - |  |


一般我们是直接写在下面的：

zombieJ · 2025-04-07T03:33:44Z

components/bubble/Bubble.tsx

+    node: React.ReactNode | ((content: BubbleContentType) => React.ReactNode),
+  ) => {
+    if (typeof node === 'function') {
+      return node(typedContent);


参考 https://github.com/ant-design/x/pull/683/files#r2024143462 调整一下？

feat: 调整Bubble foot,header参数,支持头部获取上下文

8639560

petercat-assistant bot reviewed Apr 1, 2025

View reviewed changes

components/bubble/demo/header-and-footer.tsx Outdated Show resolved Hide resolved

L-Hknu mentioned this pull request Apr 1, 2025

bubble的footer,header 支持参数传递,满足场景多样 #678

Closed

17 tasks

fix: # 支持useXAgent通过deps 获取最新状态

77ab4d5

afc163 reviewed Apr 1, 2025

View reviewed changes

fix: 剔多余提交

b70f3ab

afc163 reviewed Apr 1, 2025

View reviewed changes

components/bubble/demo/header-and-footer.tsx Outdated Show resolved Hide resolved

afc163 reviewed Apr 1, 2025

View reviewed changes

components/bubble/demo/header-and-footer.tsx Outdated Show resolved Hide resolved

afc163 reviewed Apr 1, 2025

View reviewed changes

components/bubble/index.en-US.md Outdated Show resolved Hide resolved

fix: 英文文档格式修复

b4b4e89

L-Hknu and others added 2 commits April 1, 2025 16:49

fix 简化参数

648a254

Update header-and-footer.tsx

a72e6c3

fix: 调整用例

zombieJ reviewed Apr 2, 2025

View reviewed changes

zombieJ requested changes Apr 7, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: 调整Bubble foot,header参数,支持头部获取上下文 #683

feat: 调整Bubble foot,header参数,支持头部获取上下文 #683

L-Hknu commented Apr 1, 2025

coderabbitai bot commented Apr 1, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

github-actions bot commented Apr 1, 2025 •

edited

Loading

petercat-assistant bot commented Apr 1, 2025

L-Hknu commented Apr 1, 2025 •

edited

Loading

afc163 Apr 1, 2025

L-Hknu Apr 1, 2025

afc163 Apr 1, 2025

L-Hknu Apr 1, 2025

afc163 Apr 1, 2025

L-Hknu Apr 1, 2025

zombieJ Apr 2, 2025

codecov bot commented Apr 1, 2025 •

edited

Loading

Assets Changed:

afc163 commented Apr 2, 2025

L-Hknu commented Apr 2, 2025

zombieJ Apr 2, 2025

zombieJ Apr 7, 2025

feat: 调整Bubble foot,header参数,支持头部获取上下文 #683

Are you sure you want to change the base?

feat: 调整Bubble foot,header参数,支持头部获取上下文 #683

Conversation

L-Hknu commented Apr 1, 2025

🤔 This is a ...

🔗 Related Issues

💡 Background and Solution

📝 Change Log

coderabbitai bot commented Apr 1, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

github-actions bot commented Apr 1, 2025 • edited Loading

petercat-assistant bot commented Apr 1, 2025

Walkthrough

Changes

L-Hknu commented Apr 1, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Apr 1, 2025 • edited Loading

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

afc163 commented Apr 2, 2025

L-Hknu commented Apr 2, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot commented Apr 1, 2025 •

edited

Loading

L-Hknu commented Apr 1, 2025 •

edited

Loading

codecov bot commented Apr 1, 2025 •

edited

Loading