Use installed cert (key3.db) lmt as basis for install logic#17
Open
bdurrow wants to merge 2 commits intoantevens:masterfrom
Open
Use installed cert (key3.db) lmt as basis for install logic#17bdurrow wants to merge 2 commits intoantevens:masterfrom
bdurrow wants to merge 2 commits intoantevens:masterfrom
Conversation
Motivation: If the cert install fails it will not get installed on subsiquent runs and the installed certificate will eventually expire. Caveats: This patch assumes that the letsencrypt_live_dir directory is only used for a single cert; I'm not sure how sound this assumption is.
bdurrow
force-pushed
the
installed_cert_test
branch
from
cafd177 to
0685218
Compare
bdurrow
changed the title
Owner
|
Hey Brad, Thanks for the MR, I'll review/merge as soon as I can. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
c9b7004:
Bring fatal error output in line with others.
0685218:
Use installed cert (key3.db) lmt as basis for install logic
Motivation: If the cert install fails it will not get installed on
subsiquent runs and the installed certificate will eventually expire.
Caveats: This patch assumes that the letsencrypt_live_dir directory is only
used for a single cert; I'm not sure how sound this assumption is.