Skip to content
This repository has been archived by the owner on Feb 7, 2024. It is now read-only.

feat: support unwasm condition for core #97

Merged
merged 2 commits into from
Jan 16, 2024
Merged

feat: support unwasm condition for core #97

merged 2 commits into from
Jan 16, 2024

Conversation

antfu
Copy link
Owner

@antfu antfu commented Jan 15, 2024

#71

Copy link

netlify bot commented Jan 15, 2024

Deploy Preview for shikiji ready!

Name Link
🔨 Latest commit 3dc34f9
🔍 Latest deploy log https://app.netlify.com/sites/shikiji/deploys/65a6f1b1e7308b0008cfaa61
😎 Deploy Preview https://deploy-preview-97--shikiji.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (311ca69) 97.02% compared to head (5427f26) 96.77%.
Report is 11 commits behind head on main.

❗ Current head 5427f26 differs from pull request most recent head 3dc34f9. Consider uploading reports for the commit 3dc34f9 to get more accurate results

Files Patch % Lines
packages/shikiji/src/core-unwasm.ts 0.00% 9 Missing and 1 partial ⚠️
packages/shikiji-core/src/internal.ts 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #97      +/-   ##
==========================================
- Coverage   97.02%   96.77%   -0.26%     
==========================================
  Files          50       51       +1     
  Lines        4470     4492      +22     
  Branches      567      570       +3     
==========================================
+ Hits         4337     4347      +10     
- Misses        131      142      +11     
- Partials        2        3       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -23,7 +23,8 @@
},
"./core": {
"types": "./dist/core.d.mts",
"default": "./dist/core.mjs"
"default": "./dist/core.mjs",
"unwasm": "./dist/core-unwasm.mjs"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be before default as order matters

packages/shikiji/package.json Outdated Show resolved Hide resolved
@antfu antfu merged commit 7124990 into main Jan 16, 2024
10 of 11 checks passed
@antfu antfu deleted the feat/unwasm-core branch January 16, 2024 21:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants