fix: cyclonedx handling of user defined component id #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cyclondx generator, replace self._save_element(product, str(id) + "-" + product, my_id) by self._save_element(product, my_id, my_id) as already done in spdx generator since commit 6b007bf Otherwise, if the user provides an id through the set_id function, it will not be taken into account Signed-off-by: Fabrice Fontaine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cyclondx generator, replace
self._save_element(product, str(id) + "-" + product, my_id)byself._save_element(product, my_id, my_id)as already done in spdx generator since commit 6b007bfOtherwise, if the user provides an id through the
set_idfunction, it will not be taken into account