Repository navigation
decode: retain incompatible wire types as unknown fields - #732
Open
vladislav-miroshnikov wants to merge 1 commit into
Open
vladislav-miroshnikov wants to merge 1 commit into
vladislav-miroshnikov wants to merge 1 commit into
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
recheck |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a known field shows up with an incompatible wire type, generated decoding currently fails.
DynamicMessagealready treats such records as unknown fields, and this makes generated code do the same. A well-formed record goes through the unknown-field path and is kept or dropped depending on the message config. An earlier value of a singular or oneof field is kept, and malformed input still errors.This covers owned, eager, lazy and table decoding. Most of the diff is regenerated checked-in code.
I left key/value records inside map entries alone, so they keep the strict checks from #387.
Regression tests cover kept values, defaults, unknown fields, packed and unpacked input, and malformed records. Lint, tests, arbitrary and docs pass on Linux.
Fixes #717.