Repository navigation
perf(text): scan long textproto literals with memchr - #795
Open
fallintoplace wants to merge 1 commit into
Open
fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Scan long textproto string literals with
memchr3.Why
lex_string_runchecks each byte in long unescaped strings.Implementation
memchroptional and preserveno_stdsupport.Benchmark
Tokenizer microbenchmark on Apple M1 Pro, Rust 1.95 release. Exact upstream base versus this branch, seven alternating runs; median ns/op. Lower is better.
The 16 B case is about 3% slower and dense escapes about 14% slower in this run. Large plain literals are much faster. Benchmark harness.