Remove firewall feature from claude-code #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The firewall functionality is orthogonal to Claude Code and doesn't belong in this devcontainer feature. Users who need network restrictions can implement firewall rules separately in their own devcontainer configurations. This commit removes all firewall-related code and documentation, simplifying the feature to focus solely on installing the Claude Code CLI. Changes: - Remove firewall option from devcontainer-feature.json - Remove firewall-related functions and logic from install.sh - Delete init-firewall.sh script - Remove firewall test scenarios and test files - Update NOTES.md to remove firewall documentation Run the basic test scenario to ensure Claude Code CLI still installs correctly without the firewall code. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
The firewall feature has been completely removed, so the tests should no longer check for the existence of the firewall script. ## Test plan CI should now pass without looking for the firewall script. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
igorkofman
approved these changes
Jun 12, 2025
|
@chrislloyd how can I pin the version of the feature to get the firewall? |
Contributor
Author
|
You can specify version 1.0.5 in your "features": {
"ghcr.io/anthropics/devcontainer-features/claude-code:1.0.5": {}
}For the moment until we bump, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Run the basic test scenario to ensure Claude Code CLI still installs correctly without the firewall code.
🤖 Generated with Claude Code