🧪 [testing improvement] Add error path test for normalize_number#204
Open
adamdaphna18-design wants to merge 1 commit into
Conversation
Added tests for `normalize_number` in `extract_numbers.py` to handle un-parseable strings by returning 0.0, as well as happy path tests for various units. 🎯 What: Missing error path test in `normalize_number` 📊 Coverage: Added tests for `ValueError` handling (invalid strings) and happy path (unit multipliers K, M, B, T) ✨ Result: Increased test coverage and reliability for number extraction utility Co-authored-by: adamdaphna18-design <224025798+adamdaphna18-design@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added tests for
normalize_numberinextract_numbers.pyto handle un-parseable strings by returning 0.0, as well as happy path tests for various units.🎯 What: Missing error path test in
normalize_number📊 Coverage: Added tests for
ValueErrorhandling (invalid strings) and happy path (unit multipliers K, M, B, T)✨ Result: Increased test coverage and reliability for number extraction utility