Skip to content

feat: make list behavior more intuitive#49

Open
bcExpt1123 wants to merge 2 commits intoantoniorodr:mainfrom
bcExpt1123:feat/list-not-intuitive
Open

feat: make list behavior more intuitive#49
bcExpt1123 wants to merge 2 commits intoantoniorodr:mainfrom
bcExpt1123:feat/list-not-intuitive

Conversation

@bcExpt1123
Copy link
Copy Markdown

What this changes

This PR updates the list behavior to make it more intuitive and align it with the idea in issue #36. It improves the user experience by adjusting how the list works so it behaves in a more expected way.

Related Issues

resolves #36

How I tested this

Tab navigation between sections

  • Press Tab to switch focus between:
    • Local tab → Servers tab
    • Servers tab → Local tab

Servers tab behavior

  • Connect to a server in Servers tab
  • Verify keyboard navigation:
    • Press J to move focus from the server tree → cron table
    • Press J again to move focus from cron table → server tree
  • Press Tab to move focus out of the Servers tab (to Local tab)

Checklist

  • I have read CONTRIBUTING.md and this PR follows the guidelines
  • A human has reviewed the entire diff of this PR, every line of code
  • A human understands the changes and can explain why this approach is correct
  • This PR doesn't have AI-generated boilerplate or co-author lines
  • This PR was authored and submitted by an AI agent without human review

@bcExpt1123
Copy link
Copy Markdown
Author

Hi @antoniorodr
Could you please take a look at this PR when you have a moment? I’d really appreciate your feedback.

@antoniorodr
Copy link
Copy Markdown
Owner

Hi @bcExpt1123

Thank you for this PR!

I am now testing it a bit, but I do not find how to use the jump feature you are talking about. Could you please provide a bit more details about how to use it?

What I see is that with tab you can change the tab and with jkhl you move withing the current tab. What J does?

Thanks!

@bcExpt1123
Copy link
Copy Markdown
Author

Hi @bcExpt1123

Thank you for this PR!

I am now testing it a bit, but I do not find how to use the jump feature you are talking about. Could you please provide a bit more details about how to use it?

What I see is that with tab you can change the tab and with jkhl you move withing the current tab. What J does?

Thanks!

Hi @antoniorodr
Thanks for reviewing my PR.

We can use Tab to switch between the Local and Servers tabs. However, within the Servers tab, we also need a way to move focus between the left server tree and the main content (the cron table).

Since Tab is already used for switching tabs, it can’t be reused for this interaction. The jkhl keys are also not suitable for this purpose.

As discussed in issue #36, we need a dedicated key for this action (similar to a “jump” behavior). To address this, I introduced a new shortcut: Shift + j.(J means Shift+j)

When pressed within the Servers tab, Shift + j toggles focus between:

  • the server tree (left panel), and
  • the cron table (main content)

This serves as an alternative to Tab for intra-tab focus switching, while keeping Tab reserved for switching between tabs.

@antoniorodr
Copy link
Copy Markdown
Owner

Thanks for the explanation!

Of course, I did not try to move focus to the main content withing the servers tab, I am sorry.

I will continue reviewing the code. I will come back to you if I have any questions.

Thanks!

Copy link
Copy Markdown
Owner

@antoniorodr antoniorodr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have merged this PR to another branch, so it will be released in the next version. Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Make list not intuitive

2 participants