Skip to content

feat: prompt xcframework_name to avoid duplicate target names error in Xcode#66

Open
setoelkahfi wants to merge 2 commits intoantoniusnaumann:mainfrom
setoelkahfi:feature/prompt-xcframework_name
Open

feat: prompt xcframework_name to avoid duplicate target names error in Xcode#66
setoelkahfi wants to merge 2 commits intoantoniusnaumann:mainfrom
setoelkahfi:feature/prompt-xcframework_name

Conversation

@setoelkahfi
Copy link

@setoelkahfi setoelkahfi commented Aug 28, 2024

Thanks for this crate!

I tried to generate multiple Swift packages and include them in one project, but Xcode complained about duplicate target names. This is because the generated xcframework names are all the same. Strangely, I didn't get the prompt to supply the xcframework name like the package name prompt. This PR adds that prompt, with the default name being CrateName+XCFramework.

@setoelkahfi setoelkahfi changed the title prompt xcframework_name to avoid duplicate target names error in Xcode feat: prompt xcframework_name to avoid duplicate target names error in Xcode Aug 28, 2024
@antoniusnaumann
Copy link
Owner

antoniusnaumann commented Aug 30, 2024

I would like to avoid prompting this. Most of the time, there is no need for seeing the xcframework name, so a command line flag is sufficient. For the same reason, I will not offer a short flag here.

I agree, however, that the default name should be crate specific, thanks for pointing this out!

@setoelkahfi
Copy link
Author

setoelkahfi commented Aug 30, 2024

Ok. Do you want me to close this PR? Or, I can remove the things you don't like and keep the xcframework default name change. What do you think @antoniusnaumann?

@antoniusnaumann
Copy link
Owner

Hi @setoelkahfi, sorry for not getting back to you sooner. I am not sure what exactly the situation is where you are running into issues (and hence need to set the XCFramework name).

I would be open to merge this PR, if the (1) prompt and (2) short flag are removed so this can be configured via a long-flag as sort of an expert feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants