Fix: updateTitle regex to match headings without trailing newlines #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hii @antonmedv .
I had fixed the following code problem.
Problem:
The updateTitle() function uses a regex that requires a newline after the heading:
/^\n*#(.+)\n/This causes the page title to fail updating when:
Example Case:
Solution
Updated regex to:
/^#\s*(.+)/mWith
.trim()on captured text:What This Fixes:
Test cases to verify:
Before:
After: