Reorganize VulkanEngine class structure#91
Open
Jonnydevp wants to merge 4 commits intoanunknowperson:mainfrom
Open
Reorganize VulkanEngine class structure#91Jonnydevp wants to merge 4 commits intoanunknowperson:mainfrom
Jonnydevp wants to merge 4 commits intoanunknowperson:mainfrom
Conversation
Tydik42
requested changes
Apr 24, 2025
Collaborator
Tydik42
left a comment
Tydik42
left a comment
There was a problem hiding this comment.
Посмотрел только часть, нужно ребейзнуться на main, без этого никакого смысла рефакторить vk_engine нет. Ещё, очень важно: очень много чего сейчас лежит в public, это нужно исправить и засунуть все в private, тогда и геттер класса будет иметь смысл.
Jonnydevp
force-pushed
the
reorganize-vk-engine
branch
from
5538dec to
2ff6f9d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Grouped public methods at the top of the class
Grouped public fields in the middle
Placed private methods at the bottom
Added minimal section comments for better navigation
No functional changes, only code organization improvements.