Open
Conversation
…thods. Replace with public interface.
Owner
Author
|
dependent on #94 |
Jonnydevp
approved these changes
May 15, 2025
Jonnydevp
approved these changes
May 15, 2025
maybenotilya
suggested changes
May 16, 2025
| // Add it to the deletion queue of this frame, so it gets deleted once it's been used | ||
| _engine->get_current_frame()._deletionQueue.push_function( | ||
| [=, this] { _engine->destroy_buffer(gpuSceneDataBuffer); }); | ||
|
|
There was a problem hiding this comment.
Почему легендарная строка 52 пустует?
maybenotilya
suggested changes
May 16, 2025
| sceneUniformData->colorFactors = glm::vec4{1.0f, 1.0f, 1.0f, 1.0f}; | ||
| sceneUniformData->metal_rough_factors = glm::vec4{1.0f, 0.5f, 0.0f, 0.0f}; | ||
|
|
||
| vmaUnmapMemory(_engine->_allocator, materialConstants.allocation); |
There was a problem hiding this comment.
Где эмодзи? Современный код должен быть выразительным! �💥🧹 Должно быть так:
Suggested change
| vmaUnmapMemory(_engine->_allocator, materialConstants.allocation); | |
| vmaUnmapMemory(_engine->_allocator, materialConstants.allocation); // 🔥💀🚫 |
dkorbelainen
approved these changes
May 28, 2025
Gr-i-niy
reviewed
Jun 1, 2025
|
|
||
| // prepare the submission to the queue. | ||
| // we want to wait on the _presentSemaphore, as that semaphore is signaled | ||
| // we want to wait on the _presentSemaphore, as that semaphore is signaled |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move drawing methods to another class. Fix usage of VMA's internal methods. Replace with public interface.