feat: concurrency-safe append claim and run commands - #45
Merged
Merged
Conversation
Adds graphkeeper append claim/run that write through a shared optimistic-write helper (exclusive graph-file lock + compare-before-rename with bounded retry), closing a read-modify-write race that silently dropped concurrent writers' records. - add src/lib/optimistic-write.ts (mutateJsonArrayFile, acquireLock, writeJsonArrayUnderLock) - add src/commands/append.ts and wire append claim/run into the CLI - append claim acquires claims.json then runs.json locks up front and writes both in one critical section, so a run closed mid-flight cannot orphan a claim - add GK400 (write did not stabilize/lock timeout) and GK401 (invalid input) - SKILL.md prescribes the append commands instead of direct JSON editing - tests: helper race, command race, mid-flight close, and pre-staged closed-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a read-modify-write race on graph/claims.json and graph/runs.json where two concurrent agents silently dropped one writer's record.
What changed
mutateJsonArrayFile/acquireLock/writeJsonArrayUnderLock— exclusive graph-file lock (atomic hard-link) + compare-before-rename + bounded retry (default 5).graphkeeper append claimandgraphkeeper append run.append claimacquires claims.json then runs.json locks up front and writes both in one critical section, so a run closed mid-flight cannot orphan a claim.Verification
Notes
specs/,.specify/,PROGRESS.mdare git-ignored local SDD artifacts (not in the PR).